Bug 549274 – sys-boot/grub-2.02_beta2-r7 don't recognize new ZFS features hole_birth and embedded_data

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description nico 2015-05-12 14:36:32 UTC]

When using ZFS on root, grub2 is not able to find the ZFS filesystem after a pool upgrade.


Reproducible: Always

Steps to Reproduce:
grub2-probe -t fs /


Actual Results:  
grub-probe error: unknown filesystem

Expected Results:  
zfs

grub-2.02_beta2-r7.ebuild call epatch_user.

So adding the patch grub-2.00-zfs-feature-flag-support-hole_birth-embedded_data.patch into /etc/portage/patches/sys-boot/grub fix the problem.

[Comment 1 nico 2015-05-12 14:38:23 UTC]

Created attachment 403132 [details, diff]
grub-2.00-zfs-feature-flag-support-hole_birth-embedded_data.patch

[Comment 2 nico 2015-05-12 14:39:49 UTC]

Comment on attachment 403132 [details, diff]
grub-2.00-zfs-feature-flag-support-hole_birth-embedded_data.patch

add zfs features : hole_birth and embedded_data

[Comment 3 Mike Gilbert 2015-05-12 15:25:14 UTC]

Comment on attachment 403132 [details, diff]
grub-2.00-zfs-feature-flag-support-hole_birth-embedded_data.patch

Err, that patch seems a bit small. The patches that were applied upstream seem quite a bit more complex than adding a string to an array.

[Comment 4 nico 2015-05-12 15:59:34 UTC]

The goal of this draft-patch is not to implement new features into grub, but only to be able to boot after a pool upgrade.

[Comment 5 Mike Gilbert 2015-05-12 16:50:03 UTC]

(In reply to nico from comment #4)
> The goal of this draft-patch is not to implement new features into grub, but
> only to be able to boot after a pool upgrade.

What happens when grub encounters data id doesn't know how to properly deal with?

[Comment 6 nico 2015-05-13 14:06:08 UTC]

(In reply to Mike Gilbert from comment #5)
> (In reply to nico from comment #4)
> > The goal of this draft-patch is not to implement new features into grub, but
> > only to be able to boot after a pool upgrade.
> 
> What happens when grub encounters data id doesn't know how to properly deal
> with?
it produce an error "unknow id" and drop to a grub-rescue shell...

[Comment 7 Mike Gilbert 2015-05-13 14:42:34 UTC]

Let me put it this way: I'm happy to apply patches from upstream. I'm not going to apply the patch you attached to this bug report.

[Comment 8 Svyatoslav Ivashkevich 2015-10-04 19:34:12 UTC]

Created attachment 413742 [details, diff]
Adds support of com.delphix:hole_birth, com.delphix:extensible_dataset, com.delphix:embedded_data and org.open-zfs:large_blocks ZFS features to Grub

This is just fixed patch from https://github.com/zfsonlinux/grub/blob/snapshot/debian/wheezy/2.02-beta2.9-ZOL10-7aa9f6-wheezy/debian/patches/zfs.patch .

Full ebuild is available at https://github.com/hac0demon/hac0verlay/tree/master/sys-boot/grub .

[Comment 9 Ryan Holt 2016-01-26 01:42:23 UTC]

@Svyatoslav Ivashkevich -

Thank you very much for posting your patch! Just through an additional epatch line into sys-boot/grub-2.02_beta2-r9 (rev'd to r10 in a local repository) and it worked just fine.

Had me scratching my head for the last couple days -- didn't think about the zpool upgrade that I did earlier in the day prior to a reboot.

Thanks!
Ryan