5491 – failed patch in ncurses-5.2.20020511-r1

Bug 5491 - failed patch in ncurses-5.2.20020511-r1

Summary: failed patch in ncurses-5.2.20020511-r1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	Highest critical (vote)
Assignee:	Brandon Low (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2002-07-24 00:02 UTC by Mark Guertin
Modified:	2002-08-26 23:44 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Guertin 2002-07-24 00:02:45 UTC

** Configuration summary for NCURSES 5.2 20020511:

      bin directory: /usr/bin
      lib directory: /lib
  include directory: /usr/include
      man directory: /usr/share/man
 terminfo directory: /usr/share/terminfo

patching file c++/cursesw.cc
Hunk #1 FAILED at 51.
Hunk #2 FAILED at 72.
2 out of 2 hunks FAILED -- saving rejects to file c++/cursesw.cc.rej

Not sure of exact repercussions, just noticed this while tracing another log but
don't have time to look at it :(

Comment 1 Mark Guertin 2002-07-24 01:03:19 UTC

looks like this is failed patch here:

patch -p1 <${FILESDIR}/ncurses-5.2.20020511-gcc31.patch

Comment 2 Mark Guertin 2002-08-06 13:55:28 UTC

2 weeks no reponse, let's try this one again

Comment 3 Mark Guertin 2002-08-12 15:15:34 UTC

Hmm another week rolls by...

Comment 4 Seemant Kulleen (RETIRED) gentoo-dev

2002-08-13 13:34:42 UTC

will someone please just fix this?

Comment 5 Nick Hadaway 2002-08-13 15:57:38 UTC

I have just verified compilation without error on gcc-3.1.1 (-O3 -march=athlon-
xp -pipe).  The gcc "fixes" presented by said patch are no longer valid as the 
code has changed significantly and takes into consideration, pre-gcc3 and post-
gcc-3 situations.  The patch is commented out of the ebuild currently and is 
not needed.  If you haven't done so already...

emerge rsync
emerge ncurses

Please report back on this bug report with your success or failure.

Comment 6 Mark Guertin 2002-08-13 18:01:47 UTC

This bug didn't cause me any problems personally on PPC, but I am unable to test
on x86 w/ gcc 3.1.x, and it is _very_ disheartening to watched failed patches in
core system packages, especially when it's been there un-noticed for so long.