Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 548984 - Files in eclass/tests/ should have a standard copyright header
Summary: Files in eclass/tests/ should have a standard copyright header
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-09 08:41 UTC by Ulrich Müller
Modified: 2015-11-21 20:00 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-05-09 08:41:30 UTC
These tests should all have a standard header (after the shebang, of course):

# Copyright 1999-2015 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

All committers (from CVS log) added to CC, please ack.


List of files:
   autotools_eaclocal_amflags.sh
   distutils-r1.sh
   eutils_eshopts.sh
   eutils_estack.sh
   eutils_evar.sh
   eutils_path_exists.sh
   flag-o-matic.sh
   git-r3_GIT_DIR.sh
   git-r3.sh
   git-r3_subrepos.sh
   linux-info_get_running_version.sh
   multiprocessing_makeopts_jobs.sh
   multiprocessing.sh
   python-utils-r1.sh
   savedconfig.sh
   scons-utils.sh
   tests-common.sh
   toolchain-funcs.sh
   toolchain.sh
   versionator_version_compare.sh
Comment 1 SpanKY gentoo-dev 2015-05-10 14:36:54 UTC
just do it and be done
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-05-11 15:38:21 UTC
Sure, whatever.
Comment 3 Alexis Ballier gentoo-dev 2015-05-11 16:19:09 UTC
(In reply to SpanKY from comment #1)
> just do it and be done

+1


Also, I always thought header.txt meant 'unless otherwise specified, this header applies'
Comment 4 Ulrich Müller gentoo-dev 2015-05-17 16:23:55 UTC
@reavertm, @rhill: Could you please ack that adding the header to eutils_eshopts.sh and toolchain.sh is o.k.:

RCS file: /var/cvsroot/gentoo-x86/eclass/tests/Attic/eutils:eshopts.sh,v
[...]
revision 1.1
date: 2011-12-17 04:28:48 +0100;  author: reavertm;  state: Exp;  commitid: 7a2d4eec0c5b4567;
Add new unit test for bug 395025

RCS file: /var/cvsroot/gentoo-x86/eclass/tests/toolchain.sh,v
[...]
revision 1.1
date: 2014-02-03 00:43:49 +0100;  author: dirtyepic;  state: Exp;  commitid: 173752eed8334567;
Add downgrade_arch_flags() to automatically replace/strip unsupported -march and instruction set flags. Add testsuite.


(In reply to Alexis Ballier from comment #3)
> Also, I always thought header.txt meant 'unless otherwise specified, this
> header applies'

Better have it explicit in each file, since there are files in the tree (like patches) which are distributed under different terms.
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2015-05-17 19:44:11 UTC
ack.
Comment 6 Ulrich Müller gentoo-dev 2015-11-21 20:00:44 UTC
(In reply to Ulrich Müller from comment #4)
> RCS file: /var/cvsroot/gentoo-x86/eclass/tests/Attic/eutils:eshopts.sh,v
> [...]
> revision 1.1
> date: 2011-12-17 04:28:48 +0100;  author: reavertm;  state: Exp;  commitid:
> 7a2d4eec0c5b4567;
> Add new unit test for bug 395025

Looking at the code of that original commit, it is (without comments) only five short lines which I doubt to be copyrightable:
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/tests/eutils%3Aeshopts.sh?hideattic=0&revision=1.1&view=markup

All the rest of eutils_eshopts.sh is from Mike who gave his ack in comment 1.

So, all done. Closing.