Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54898 - virtualx.eclass has a bug whereby virtualmake always tries spawning Xvfb
Summary: virtualx.eclass has a bug whereby virtualmake always tries spawning Xvfb
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
: 78899 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-06-23 09:30 UTC by devsk
Modified: 2006-04-22 14:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch for fixing issues with Xvfb and virtualmake (virtualx.eclass.patch,1.04 KB, patch)
2004-06-23 10:38 UTC, devsk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description devsk 2004-06-23 09:30:42 UTC
look at the patch below and you will know. the xhost command doesn't return !0 if failed. So, even if DISPLAY is set and xhost is successful, virtualx.eclass tries to spawn Xvfb. Without the patch, it works on linux but not on solaris.

----------------------------PATCH CUT BELOW THIS LINE------------------
--- virtualx.eclass.ORG 2004-06-23 09:08:29.200639510 -0700
+++ virtualx.eclass     2004-06-23 09:09:00.177314130 -0700
@@ -20,7 +20,7 @@

        #If $DISPLAY is not set, or xhost cannot connect to an X
        #display, then do the Xvfb hack.
-       if [ -z "$DISPLAY" ] || ! (/usr/X11R6/bin/xhost &>/dev/null)
+       if [ -z "$DISPLAY" ] ||  (/usr/X11R6/bin/xhost &>/dev/null)
        then
                export XAUTHORITY=
                # The following is derived from Mandrake's hack to allow
---------------------PATCH ENDS ABOVE THIS LINE--------------------

Reproducible: Always
Steps to Reproduce:
1. emerge evolution
2. 
3.

Actual Results:  
It fails to start a display server

Expected Results:  
It should connect to the existing X display.
Comment 1 devsk 2004-06-23 10:37:03 UTC
Ignore the patch specified in comment 1, use the attached patch. Actually, the problem is that virtualmake looks for started server in /tmp/.X<DISPLAY>-lock when  that file is not created. Only file created on linux and solaris is "/tmp/.X11-unix/X<DISPLAY>=". The patch fixes this as well.
Comment 2 devsk 2004-06-23 10:38:17 UTC
Created attachment 33964 [details, diff]
The patch for fixing issues with Xvfb and virtualmake
Comment 3 devsk 2004-09-19 09:39:31 UTC
the xhost test is wrong...the return value of xhost is 0 if it can connect to an existing X server and 1 if it can't. So, please remove that '!' from the test.
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2004-11-03 01:56:17 UTC
Can you just attach an updated patch, please?
Comment 5 foser (RETIRED) gentoo-dev 2005-01-23 02:34:32 UTC
*** Bug 78899 has been marked as a duplicate of this bug. ***
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2005-01-24 03:37:58 UTC
Az this is kinda your baby .. if you don't want it, send it back.
Comment 7 Joshua Baergen (RETIRED) gentoo-dev 2006-03-26 12:23:20 UTC
Is this still a problem?
Comment 8 Joshua Baergen (RETIRED) gentoo-dev 2006-04-22 14:48:08 UTC
This eclass has changed a bit since this bug was filed.  Please re-open it if the problem still exists with the current eclass.
Comment 9 Joshua Baergen (RETIRED) gentoo-dev 2006-04-22 14:49:31 UTC
Doh, I was looking at the wrong bug and didn't realize this was assigned to you Martin.  Re-open it if you'd like.