Bug 548194 – www-client/chromium-43.0.2357.18 fails to build with libsecret-0.16

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew John Hughes 2015-04-29 23:29:09 UTC]

In file included from ../../chrome/browser/password_manager/native_backend_libsecret.cc:5:0:
../../chrome/browser/password_manager/native_backend_libsecret.h:27:20: error: ‘::secret_service_search_sync’ has not been declared
   static decltype(&::secret_service_search_sync) secret_service_search_sync;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.h:29:20: error: ‘::secret_item_get_secret’ has not been declared
   static decltype(&::secret_item_get_secret) secret_item_get_secret;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.h:30:20: error: ‘::secret_value_get_text’ has not been declared
   static decltype(&::secret_value_get_text) secret_value_get_text;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.h:31:20: error: ‘::secret_item_get_attributes’ has not been declared
   static decltype(&::secret_item_get_attributes) secret_item_get_attributes;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.h:32:20: error: ‘::secret_item_load_secret_sync’ has not been declared
   static decltype(&::secret_item_load_secret_sync) secret_item_load_secret_sync;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.h:33:20: error: ‘::secret_value_unref’ has not been declared
   static decltype(&::secret_value_unref) secret_value_unref;
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:31:9: error: ‘::secret_service_search_sync’ has not been declared
 typeof(&::secret_service_search_sync)
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:32:48: error: invalid type in declaration before ‘;’ token
     LibsecretLoader::secret_service_search_sync;
                                                ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:35:9: error: ‘::secret_item_get_secret’ has not been declared
 typeof(&::secret_item_get_secret) LibsecretLoader::secret_item_get_secret;
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:35:74: error: invalid type in declaration before ‘;’ token
 typeof(&::secret_item_get_secret) LibsecretLoader::secret_item_get_secret;
                                                                          ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:36:9: error: ‘::secret_value_get_text’ has not been declared
 typeof(&::secret_value_get_text) LibsecretLoader::secret_value_get_text;
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:36:72: error: invalid type in declaration before ‘;’ token
 typeof(&::secret_value_get_text) LibsecretLoader::secret_value_get_text;
                                                                        ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:37:9: error: ‘::secret_item_get_attributes’ has not been declared
 typeof(&::secret_item_get_attributes)
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:38:48: error: invalid type in declaration before ‘;’ token
     LibsecretLoader::secret_item_get_attributes;
                                                ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:39:9: error: ‘::secret_item_load_secret_sync’ has not been declared
 typeof(&::secret_item_load_secret_sync)
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:40:50: error: invalid type in declaration before ‘;’ token
     LibsecretLoader::secret_item_load_secret_sync;
                                                  ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:41:9: error: ‘::secret_value_unref’ has not been declared
 typeof(&::secret_value_unref) LibsecretLoader::secret_value_unref;
         ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:41:66: error: invalid type in declaration before ‘;’ token
 typeof(&::secret_value_unref) LibsecretLoader::secret_value_unref;
                                                                  ^
../../chrome/browser/password_manager/native_backend_libsecret.cc: In static member function ‘static bool LibsecretLoader::LibsecretIsAvailable()’:
../../chrome/browser/password_manager/native_backend_libsecret.cc:269:45: error: ‘SECRET_SEARCH_ALL’ was not declared in this scope
                                             SECRET_SEARCH_ALL,
                                             ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:271:51: error: ‘LibsecretLoader::secret_service_search_sync’ cannot be used as a function
                                             &error);
                                                   ^
../../chrome/browser/password_manager/native_backend_libsecret.cc: In member function ‘ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::AddUpdateLoginSearch(const autofill::PasswordForm&, NativeBackendLibsecret::AddUpdateLoginSearchOptions)’:
../../chrome/browser/password_manager/native_backend_libsecret.cc:411:45: error: ‘SECRET_SEARCH_ALL’ was not declared in this scope
                                             SECRET_SEARCH_ALL,
                                             ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:413:51: error: ‘LibsecretLoader::secret_service_search_sync’ cannot be used as a function
                                             &error);
                                                   ^
../../chrome/browser/password_manager/native_backend_libsecret.cc: In member function ‘bool NativeBackendLibsecret::GetLoginsList(const autofill::PasswordForm*, NativeBackendLibsecret::GetLoginsListOptions, ScopedVector<autofill::PasswordForm>*)’:
../../chrome/browser/password_manager/native_backend_libsecret.cc:500:45: error: ‘SECRET_SEARCH_ALL’ was not declared in this scope
                                             SECRET_SEARCH_ALL,
                                             ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:502:51: error: ‘LibsecretLoader::secret_service_search_sync’ cannot be used as a function
                                             &error);
                                                   ^
../../chrome/browser/password_manager/native_backend_libsecret.cc: In member function ‘ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(GList*, const autofill::PasswordForm*)’:
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:5: error: ‘SecretItem’ was not declared in this scope
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
     ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:17: error: ‘secretItem’ was not declared in this scope
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
                 ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:42: error: ‘SecretItem’ does not name a type
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
                                          ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:52: error: expected ‘>’ before ‘*’ token
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
                                                    ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:52: error: expected ‘(’ before ‘*’ token
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:53: error: expected primary-expression before ‘>’ token
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
                                                     ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:572:69: error: expected ‘)’ before ‘;’ token
     SecretItem* secretItem = static_cast<SecretItem*>(element->data);
                                                                     ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:573:78: error: ‘LibsecretLoader::secret_item_load_secret_sync’ cannot be used as a function
     LibsecretLoader::secret_item_load_secret_sync(secretItem, nullptr, &error);
                                                                              ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:580:62: error: ‘LibsecretLoader::secret_item_get_attributes’ cannot be used as a function
     GHashTable* attrs = secret_item_get_attributes(secretItem);
                                                              ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:597:7: error: ‘SecretValue’ was not declared in this scope
       SecretValue* secretValue = secret_item_get_secret(secretItem);
       ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:597:20: error: ‘secretValue’ was not declared in this scope
       SecretValue* secretValue = secret_item_get_secret(secretItem);
                    ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:597:67: error: ‘LibsecretLoader::secret_item_get_secret’ cannot be used as a function
       SecretValue* secretValue = secret_item_get_secret(secretItem);
                                                                   ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:599:77: error: ‘LibsecretLoader::secret_value_get_text’ cannot be used as a function
         form->password_value = UTF8ToUTF16(secret_value_get_text(secretValue));
                                                                             ^
../../chrome/browser/password_manager/native_backend_libsecret.cc:600:39: error: ‘LibsecretLoader::secret_value_unref’ cannot be used as a function
         secret_value_unref(secretValue);


Reproducible: Always

Steps to Reproduce:
1. Build chromium 43.0.2357.1 with libsecret-0.16 installed
2.
3.
Actual Results:  
Build fails.

Expected Results:  
Build succeeds.

Build succeeds when libsecret is upgraded to 0.18, so Chromium needs to depend on a new enough version.

[Comment 1 Mike Gilbert 2015-04-30 01:48:23 UTC]

Please attach a build log and provide emerge --info.

[Comment 2 Paweł Hajdan, Jr. (RETIRED) 2015-05-06 13:35:38 UTC]

Actually all versions of chromium in tree are affected by this, including 42.x. I have reproduced the failure and will update the dependencies.

[Comment 3 Paweł Hajdan, Jr. (RETIRED) 2015-05-06 20:02:20 UTC]

Aand it's fixed. Thanks for the report.