Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 548046 - net-libs/libvncserver-0.9.10-r1 tests are not disabled
Summary: net-libs/libvncserver-0.9.10-r1 tests are not disabled
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alex Xu (Hello71)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 18:05 UTC by Guillaume Horel
Modified: 2015-05-13 22:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Horel 2015-04-28 18:05:13 UTC
One of the sed line in the ebuild got "fixed" by going from libvncserver-0.9.9* to libvnserver-0.9.10*.

In 0.9.9:
"/^SUBDIRS/s:\<($(use test || echo 'test|')client_examples|examples)\>::g"
In 0.9.10:
"/^SUBDIRS/s:\<($(usex test 'test|' '')client_examples|examples)\>::g"

which is not what you want $(use test || echo 'test|') is 'test|' iff test is false, so if you want to use the usex construct, it should be:
"/^SUBDIRS/s:\<($(usex test '' 'test|')client_examples|examples)\>::g"

Reproducible: Always

Steps to Reproduce:
install the ebuild and notice that tests get compiled.
Comment 1 Alex Xu (Hello71) 2015-04-28 21:57:33 UTC
oh yeah. oops. welp, guess it's time to make a -r2. /me sighs
Comment 2 Alex Xu (Hello71) 2015-05-13 22:58:01 UTC
fixed in -r2 (or is it -r3, I really don't know at this point)