Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 548000 - x11-misc/xbindkeys-1.8.6 binding stops working after layout change
Summary: x11-misc/xbindkeys-1.8.6 binding stops working after layout change
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-04-28 12:22 UTC by Vytenis Sodaitis
Modified: 2020-02-19 18:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix layout patch (fix_layout.patch,986 bytes, patch)
2015-04-28 12:22 UTC, Vytenis Sodaitis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vytenis Sodaitis 2015-04-28 12:22:16 UTC
Created attachment 402158 [details, diff]
fix layout patch

Stumbled on exactly same problem like in this mail list: https://lists.gnu.org/archive/html/xbindkeys-devel/2014-02/msg00000.html
There is a patch fixing that, and it got merged upstream, but no new version has came out for a year already.
Maybe this patch could get included in portage?
Comment 1 Alexey Chernov 2019-09-11 19:03:50 UTC
I tend to second it, just switched to Gentoo from LFS and after xbindkeys version update noticed this problem. Is there any way to make a ebuild change proposal for applying this patch? Would be glad to do it.
Comment 2 Benda Xu gentoo-dev 2020-02-14 08:00:25 UTC
fix in 3a912eb430ddaddc743756948.
Comment 3 Juha Aatrokoski 2020-02-18 21:57:13 UTC
The patch here is broken: it uses logical AND instead of bitwise AND, causing the state to be AND'ed with 1. Theis breaks e.g. my "mod4 + b:1" binding. The upstream git has the correct patch with bitwise AND.
Comment 4 Alexey Chernov 2020-02-19 18:14:33 UTC
(In reply to Juha Aatrokoski from comment #3)
> The patch here is broken: it uses logical AND instead of bitwise AND,
> causing the state to be AND'ed with 1. Theis breaks e.g. my "mod4 + b:1"
> binding. The upstream git has the correct patch with bitwise AND.

Sorry, this is me who created the pull request adding the patch. I was actually aware of this error, but the wrong version of the patch was occasionally overseen and included. I've created the pull request with the fix (I've double checked the patch is taken from the upstream this time), here: https://github.com/gentoo/gentoo/pull/14706, but no estimations on when it would be reviewed, the previous version had been there for more, than 6 months without any reply.