Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 547926 - dev-python/setuptools-15.0: do not install broken filename 'script (dev).tmpl'
Summary: dev-python/setuptools-15.0: do not install broken filename 'script (dev).tmpl'
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
: 622138 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-27 19:17 UTC by Martin Mokrejš
Modified: 2017-06-22 20:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Mokrejš 2015-04-27 19:17:50 UTC
$ ls -latr /usr/lib64/python2.7/site-packages/setuptools
total 548
-rw-r--r--   1 root root  1821 Mar 28 15:55 extension.py
-rw-r--r--   1 root root 35222 Mar 28 15:55 dist.py
-rw-r--r--   1 root root  6370 Mar 28 15:55 depends.py
-rw-r--r--   1 root root  2094 Mar 28 15:55 compat.py
-rw-r--r--   1 root root  6609 Mar 28 15:55 archive_util.py
-rw-r--r--   1 root root  5033 Mar 28 15:55 __init__.py
-rw-r--r--   1 root root   714 Mar 28 15:55 windows_support.py
-rw-r--r--   1 root root   293 Mar 28 15:55 utils.py
-rw-r--r--   1 root root   981 Mar 28 15:55 unicode_utils.py
-rw-r--r--   1 root root  8044 Mar 28 15:55 ssl_support.py
-rw-r--r--   1 root root  2389 Mar 28 15:55 site-patch.py
-rw-r--r--   1 root root   138 Mar 28 15:55 script.tmpl
-rw-r--r--   1 root root   201 Mar 28 15:55 script (dev).tmpl


Maybe both *.tmpl files are crap?
Comment 1 Mike Gilbert gentoo-dev 2015-04-27 19:33:10 UTC
What is wrong with it? It seems like a perfectly legal file name to me.
Comment 3 Martin Mokrejš 2015-04-27 20:11:33 UTC
Thanks for the commit links, that brought me to https://bitbucket.org/pypa/setuptools/issue/134

That guy is joking.
Comment 4 Mike Gilbert gentoo-dev 2015-04-27 20:21:16 UTC
Oh, you are referring to spaces and parens in filenames. That's certainly nothing broken; you are just misusing your tools.

portage supports such filenames without any issue.
Comment 5 Martin Mokrejš 2015-04-27 20:30:58 UTC
Well, while reporting this here I really thought the "script (dev).tmpl" file was installed by mistake. The commit you found explained it is intentionally named in this way and I can only hope it is to be installed under that name.



I agree wrapping filenames in shell by quotes is a good practice but there are ton's of proggram which do NOT do the right thing. My point (in the bitbucket issue) is that we should not create such nasty filenames at first. Do Requirements of setuptools say they cannot be installed onto an MS-DOS filesystem?

Either way, admittedly not a Gentoo issue. Thanks.
Comment 6 Mike Gilbert gentoo-dev 2015-04-27 20:42:14 UTC
(In reply to Martin Mokrejš from comment #5)
> Do Requirements of setuptools say they cannot be installed onto an MS-DOS
> filesystem?

I just can't resist responding to this bad example. ^_^

Python does not run on DOS. Any modern OS capable of mounting a FAT filesystem also has support for spaces in file names.

Anyway, I agree with the upstream dev in that it really does not make sense to change the file name because somebody might run a broken shell command/script. The shell script(s) need fixing, not the python package.
Comment 7 Mike Gilbert gentoo-dev 2017-06-22 20:56:41 UTC
*** Bug 622138 has been marked as a duplicate of this bug. ***