Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 547270 - xfce-base/libxfce4ui-4.12.1 - add gtk3 use flag
Summary: xfce-base/libxfce4ui-4.12.1 - add gtk3 use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-21 09:05 UTC by Karl Lindén
Modified: 2015-05-11 17:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2015-04-21 09:05:40 UTC
The libxfce4ui has an option to disable gtk3. I think it would be great to be able to opt out the gtk3 dependency through a USE flag. Here is a patch adding the USE flag.

--- libxfce4ui-4.12.1.ebuild	2015-04-21 10:53:46.010144631 +0200
+++ libxfce4ui-4.12.1-r1.ebuild	2015-04-21 11:00:30.443501401 +0200
@@ -12,17 +12,17 @@
 LICENSE="LGPL-2"
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~amd64-fbsd ~x86-fbsd ~x86-freebsd ~x86-interix ~amd64-linux ~x86-linux ~x86-solaris"
-IUSE="debug glade startup-notification"
+IUSE="debug glade +gtk3 startup-notification"
 
 RDEPEND=">=dev-libs/glib-2.30:2=
 	>=x11-libs/gtk+-2.24:2=
-	>=x11-libs/gtk+-3.2:3=
 	x11-libs/libX11:=
 	x11-libs/libICE:=
 	x11-libs/libSM:=
 	>=xfce-base/libxfce4util-4.12:=
 	>=xfce-base/xfconf-4.12:=
 	glade? ( dev-util/glade:3= )
+	gtk3? ( >=x11-libs/gtk+-3.2:3= )
 	startup-notification? ( x11-libs/startup-notification:= )
 	!xfce-base/xfce-utils"
 DEPEND="${RDEPEND}
@@ -33,9 +33,9 @@
 
 pkg_setup() {
 	XFCONF=(
-		--enable-gtk3
 		$(use_enable startup-notification)
 		$(use_enable glade gladeui)
+		$(use_enable gtk3)
 		$(xfconf_use_debug)
 		--with-vendor-info=Gentoo
 		--with-html-dir="${EPREFIX}"/usr/share/doc/${PF}/html

Note that xfce-base/garcon should depend on xfce-base/libxfce4ui[gtk3]. 

Reproducible: Always
Comment 1 Karl Lindén 2015-04-21 09:06:36 UTC
Oh, it should be: xfce-base/garcon should depend on xfce-base/libxfce4ui[gtk3(+)].
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-04-26 18:21:44 UTC
Yes, please figure out all revdeps that need fixing and preferably submit a complete PR.
Comment 3 Karl Lindén 2015-05-01 18:44:08 UTC
Pull request submitted at https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/112
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-05-11 17:55:54 UTC
+*libxfce4ui-4.12.1-r1 (11 May 2015)
+
+  11 May 2015; Michał Górny <mgorny@gentoo.org> +libxfce4ui-4.12.1-r1.ebuild,
+  metadata.xml:
+  Add gtk3 USE flag. Bug #547270, PR https://github.com/gentoo/gentoo-portage-
+  rsync-mirror/pull/112. Big thanks to Karl Lindén and brakarov.