Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 546790 - media-libs/mediastreamer-bcg729: fix deps
Summary: media-libs/mediastreamer-bcg729: fix deps
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 12:24 UTC by Jaco Kroon
Modified: 2019-12-29 14:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for fixing the dependencies (mediastreamer-bcg72x-depends.patch,379 bytes, patch)
2015-04-16 12:30 UTC, Jaco Kroon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2015-04-16 12:24:51 UTC
Should depend on media-libs/mediastreamer[ortp]

This is because without the ortp USE flag mediastreamer will not build mediastreamer_voip library, which is required by mediastreamer-bcg729.

Reproducible: Always
Comment 1 Jaco Kroon 2015-04-16 12:30:52 UTC
Created attachment 401356 [details, diff]
patch for fixing the dependencies

patch to the existing ebuild that fixes the dependency.
Comment 2 Andrew Savchenko gentoo-dev 2015-04-16 18:13:05 UTC
Fixed in mediastreamer-bcg729-1.0.0-r1.ebuild (have to drop stable keywords due to dependency change). Thanks for the report and the patch.
Comment 3 Nikoli 2015-04-17 20:53:41 UTC
The patch is wrong: net-libs/ortp should not be removed from deps. Removing deps with ':=' is bad idea, because it breaks sub-slot based rebuilding.

now RDEPEND and DEPEND have several missing deps:
dev-libs/openssl:0=
net-libs/libsrtp:=
>=net-libs/ortp-0.16.0:=

$ check-deps.sh media-plugins/mediastreamer-bcg729
 * Checking "media-plugins/mediastreamer-bcg729-1.0.0-r1"
 * Missing in RDEPEND and DEPEND:
        dev-libs/openssl
                X86_64;libcrypto.so.1.0.0
                        /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0
                X86_64;libssl.so.1.0.0
                        /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0
        net-libs/libsrtp
                X86_64;libsrtp.so.1
                        /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0
        net-libs/ortp
                X86_64;libortp.so.9
                        /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0
Comment 4 Andrew Savchenko gentoo-dev 2015-04-17 21:19:58 UTC
media-plugins/mediastreamer-bcg729 has no direct dependencies on libortp:

$ ldd /usr/lib/libbcg729.so.0.0.0
        linux-gate.so.1 (0xb77d5000)
        libc.so.6 => /lib/libc.so.6 (0xb75e0000)
        /lib/ld-linux.so.2 (0xb77d8000)

I do not know how your "check-deps.sh" script works, but I see of no reason why mediastreamer-bcg729 should directly depent on ortp (it has configure check for ortp, but mediastreamer[ortp] satisfies this check).
Comment 5 Nikoli 2015-04-17 21:46:53 UTC
My comment #3 is not about /usr/lib64/libbcg729.so.0.0.0, but about /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0

Please check your packages more carefully:

$ objdump -p /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0|grep NEEDED|sort
  NEEDED               libbcg729.so.0
  NEEDED               libcrypto.so.1.0.0
  NEEDED               libc.so.6
  NEEDED               libmediastreamer_base.so.3
  NEEDED               libmediastreamer_voip.so.3
  NEEDED               libortp.so.9
  NEEDED               libpthread.so.0
  NEEDED               librt.so.1
  NEEDED               libsrtp.so.1
  NEEDED               libssl.so.1.0.0

$ equery b /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0
 * Searching for /usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0 ... 
media-plugins/mediastreamer-bcg729-1.0.0-r1 (/usr/lib64/mediastreamer/plugins/libmsbcg729.so.0.0.0)
Comment 6 Lubos Dolezel 2015-06-15 08:34:53 UTC
I would like to kindly ask you to make the whole mediastreamer plugin and dependency optional in this ebuild.

I plan to integrate G.729A support into Twinkle SIP phone (http://twinkle.dolezel.info/) and it will only need the main library (libbcg729.so), i.e. not the plugin primarily intended for Linphone (libmsbcg729.so).

While Twinkle is not in Portage anymore - it was removed due to a dependency on Qt3 - I have ported the application to Qt4/5 and plan to maintain and improve it.
Comment 7 Andrew Savchenko gentoo-dev 2015-06-15 12:30:19 UTC
(In reply to Lubos Dolezel from comment #6)
> I would like to kindly ask you to make the whole mediastreamer plugin and
> dependency optional in this ebuild.
> 
> I plan to integrate G.729A support into Twinkle SIP phone
> (http://twinkle.dolezel.info/) and it will only need the main library
> (libbcg729.so), i.e. not the plugin primarily intended for Linphone
> (libmsbcg729.so).

File a separate bug for this. The best way will be to split package in two. Patches are welcome. Unfortunately, right now I don't have much time for linphone and mediastreamer related packages.