Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 546530 - net-misc/dahdi-2.10.1 on sys-kernel/gentoo-sources-4.0.0 - dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7056:2: error: void value not ignored as it ought to be
Summary: net-misc/dahdi-2.10.1 on sys-kernel/gentoo-sources-4.0.0 - dahdi-linux-2.10.1...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-14 07:14 UTC by Erich Seifert
Modified: 2015-05-14 13:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patches for kernel 4.x from upstream (kernel4x.diff,1.86 KB, patch)
2015-05-04 06:27 UTC, Oliver Jaksch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Seifert 2015-04-14 07:14:01 UTC
net-misc/dahdi-2.10.1 fails to compile on a system with sys-kernel/gentoo-sources-4.0.0. Upstream has solved the issue with two commits (1cc0ad510acd404e63923ed3062b9302d53580da and 1559db9d1ae03780788788c07334ca54cdd1253a).

Reproducible: Always

Steps to Reproduce:
1. emerge =sys-kernel/gentoo-sources-4.0.0
2. eselect set kernel ...
3. emerge =net-misc/dahdi-2.10.1
Actual Results:  
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘set_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7056:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘_assign_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7080:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7100:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘_check_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7150:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7156:3: error: void value not ignored as it ought to be
   dahdi_dev_dbg(ASSIGN, span_device(span),
   ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7184:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^

After commit 1cc0ad510acd404e63923ed3062b9302d53580da was applied as a patch the build still fails with:

/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/xpp/card_pri.c: In function ‘pri_protocol_store’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/xpp/card_pri.c:2402:2: error: implicit declaration of function ‘strnicmp’ [-Werror=implicit-function-declaration]
  if (strnicmp(buf, "E1", 2) == 0)
  ^


Expected Results:  
Dahdi should compile without errors.

Applying <https://github.com/asterisk/dahdi-linux/commit/1cc0ad510acd404e63923ed3062b9302d53580da.diff> and
<https://github.com/asterisk/dahdi-linux/commit/1559db9d1ae03780788788c07334ca54cdd1253a.diff> as user patches makes dahdi build fine.
Comment 1 Oliver Jaksch 2015-05-04 06:27:22 UTC
I can confirm that the patches applies and compiles fine (with kernel 3.19.3 in my case). No further tests done which follows 'til tomorrow.
Comment 2 Oliver Jaksch 2015-05-04 06:27:59 UTC
Created attachment 402588 [details, diff]
Patches for kernel 4.x from upstream
Comment 3 Oliver Jaksch 2015-05-05 07:04:36 UTC
Using the patched dahdi in production system and did some calls via dahdi/wcb4xxp. Everything is normal by now.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2015-05-14 13:21:05 UTC
+*dahdi-2.10.1-r1 (14 May 2015)
+
+  14 May 2015; Tony Vroon <chainsaw@gentoo.org> +dahdi-2.10.1-r1.ebuild:
+  Two upstream patches as scavenged by Erich Seifert & Oliver Jaksch restore
+  compatibility with kernel 4.0 and higher. Closes bug #546530.

My apologies for the severe delay gentlemen.