Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 546076 - media-sound/jack-audio-connection-kit-0.124.1 - missing cpu_flags_x86_sse2 USE flag
Summary: media-sound/jack-audio-connection-kit-0.124.1 - missing cpu_flags_x86_sse2 US...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 16:17 UTC by Karl Lindén
Modified: 2015-06-08 09:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2015-04-09 16:17:19 UTC
The build system adds -msse2 at configure.ac:473, but cpu_flags_x86_sse2 is not mentioned in the ebuild. The following snippet should be updated to take cpu_flags_x86_sse2 in account or else sse2 might be unintentionally enabled. (Also -mmmx should be dropped since it is not needed by the build system.)

	# CPU Detection (dynsimd) uses asm routines which requires 3dnow, mmx and sse.
	if use cpudetection && use cpu_flags_x86_3dnow && use cpu_flags_x86_sse ; then
		einfo "Enabling cpudetection (dynsimd). Adding -mmmx, -msse, -m3dnow and -O2 to CFLAGS."
		myconf="${myconf} --enable-dynsimd"
		append-flags -mmmx -msse -m3dnow -O2
	fi

Reproducible: Always
Comment 1 Alexis Ballier gentoo-dev 2015-06-08 09:59:11 UTC
well, it was worse: dynsimd controls even building optimized asm routines, 3dnow or sse

the -msse2 in configure.ac is just for building simd files, which are c files with only inline asm, so -msse2 shouldn't affect the rest of the build


I've updated 0.124.1 to enable dynsimd with 3dnow or sse enabled; jack should detect automatically which one to use