Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54598 - portage 2.0.51_pre10 QA IUSE complaints when flag has been defined
Summary: portage 2.0.51_pre10 QA IUSE complaints when flag has been defined
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2004-06-20 22:16 UTC by Brian Harring (RETIRED)
Modified: 2004-07-31 05:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Harring (RETIRED) gentoo-dev 2004-06-20 22:16:04 UTC
prior to debug.eclass defining IUSE as IUSE="${IUSE} debug", it exposed an issue w/ useq's QA check.

current useq QA check as of portage-2.0.51_pre10-

if ! hasq "${u}" ${IUSE} && ! hasq "${u}" ${PORTAGE_ARCHLIST} selinux; then
                echo "QA Notice: USE Flag '${u}' not in IUSE for ${CATEGORY}/${PF}" >&2
fi

Problem with this is that inherit shifts eclass IUSE definitions into E_IUSE.  After the ebuild has been completely sourced, E_IUSE is merged into IUSE.

So, inline use statements in the global scope complain that IUSE is lacking a use flag, despite the fact it exists- it has just been defined by the eclass (which is valid behaviour), but due to the use statement being in the global scope for the ebuild, the eclass's IUSE definitions haven't yet been merged.

so... it should be 
if ! hasq "${u}" ${IUSE} ${E_IUSE} && ! hasq "${u}" ${PORTAGE_ARCHLIST} selinux; then
...etc.

The modified check looks in the ebuilds defined IUSE, and in eclass defined IUSE statements.  This eliminates the invalid QA complaints.

If we're after complaining about statements in the global scope, fine, label the complaint as such- the current QA IUSE complaint about eclass defined IUSE is misleading.
Comment 1 Brian Harring (RETIRED) gentoo-dev 2004-07-31 05:47:41 UTC
pre13 is out, closing.