Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545488 - devmanual "Every ebuild must specify a KEYWORDS variable."
Summary: devmanual "Every ebuild must specify a KEYWORDS variable."
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Devmanual Team
URL: https://devmanual.gentoo.org/keywordi...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-04 10:00 UTC by Jonas Stein
Modified: 2015-06-17 12:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (0001-Live-ebuilds-need-not-specify-KEYWORDS.patch,1.17 KB, patch)
2015-05-21 16:41 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2015-04-04 10:00:29 UTC
Every ebuild must specify a KEYWORDS variable. [1]
But this is not the case as said in https://bugs.gentoo.org/show_bug.cgi?id=545444



[1] https://devmanual.gentoo.org/keywording/index.html

Reproducible: Always
Comment 1 Ulrich Müller gentoo-dev 2015-04-09 06:15:56 UTC
Can you provide a patch?
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2015-04-11 11:20:40 UTC
This is not true sorry

repoman full on an ebuild without KEYWORDS will simply report the following warning (eg on a modified redis ebuild):

RepoMan scours the neighborhood...
  KEYWORDS.missing              1
   dev-db/redis/redis-3.0.0.ebuild


So I don't think we need to fix the devmanual.
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2015-04-11 11:22:41 UTC
Since this is a warning you can still commit the ebuild which will assume KEYWORDS="" but devmanual is about documenting good practices etc so committing ebuilds with repoman warnings is not something we should encourage in documentation.
Comment 4 Ulrich Müller gentoo-dev 2015-04-11 12:09:22 UTC
What repoman reports depends on the situation. For a regular ebuild without KEYWORDS it will indeed report this:

(In reply to Markos Chandras from comment #2)
>   KEYWORDS.missing              1
>    dev-db/redis/redis-3.0.0.ebuild

(Note that it doesn't distinguish between the KEYWORDS="" and unset KEYWORDS cases.)


It is different for a live ebuild, though. Here repoman will be happy if the ebuild _doesn't_ assign a KEYWORDS variable. However, after adding KEYWORDS="~amd64" to the live ebuild, I'll get this:

RepoMan scours the neighborhood...
  LIVEVCS.unmasked              1
   app-doc/pms/pms-9999.ebuild
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2015-04-11 12:13:35 UTC
Hmm i see. Ok i guess we can re-word it a bit to mention that KEYWORDS is necessary for non-live ebuilds
Comment 6 Ulrich Müller gentoo-dev 2015-05-21 16:41:36 UTC
Created attachment 403736 [details, diff]
Proposed patch
Comment 7 Ulrich Müller gentoo-dev 2015-06-17 12:09:50 UTC
commit 1362d6608c323241ad1a4d0313046e99407ef352
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Thu May 21 18:37:11 2015 +0200

    Live ebuilds need not specify KEYWORDS.
    
    Bug 545488.