Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545370 - app-emacs/ddskk >= 14.4 SITEFILE (50ddskk-gentoo.el) fix and 15.2 version bump request.
Summary: app-emacs/ddskk >= 14.4 SITEFILE (50ddskk-gentoo.el) fix and 15.2 version bum...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-03 01:00 UTC by Teika kazura
Modified: 2016-11-27 09:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
ddskk-15.2.ebuild (ddskk-15.2.ebuild,1.65 KB, text/plain)
2015-04-03 01:01 UTC, Teika kazura 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Teika kazura 2015-04-03 01:00:56 UTC 
** Version bump request for ddskk-15.2.

Use the attached file. The epatch line in 15.1 ebuild is not necessary any more.
Furthermore, I changed the first line of src_install() It now reads:
  emake install-elc || die
  elisp-install ${PN} nicola/*.el tut-code/*.{el,elc} bayesian/*.{el,elc} || die
in contrast to the current
  elisp-install ${PN} *.{el,elc} nicola/*.el tut-code/*.{el,elc} bayesian/*.{el,elc} || die
(Notice the second argument.) Previously skk-setup.el was not generated, thus neither installed. And instead several spurious files were installed.

To this end, src_prepare() is also changed.

** SITEFILE fix
Since ddskk >= 14.4 [1], skk-setup.el includes the lines below. They should be included in SITEFILE, 50ddskk-gentoo.el :
------------------------------------------------------------------------
;;; Isearch setting.
(defun skk-isearch-setup-maybe ()
  (require 'skk-vars)
  (when (or (eq skk-isearch-mode-enable 'always)
            (and (boundp 'skk-mode)
                 skk-mode
                 skk-isearch-mode-enable))
    (skk-isearch-mode-setup)))

(defun skk-isearch-cleanup-maybe ()
  (require 'skk-vars)
  (when (and (featurep 'skk-isearch)
             skk-isearch-mode-enable)
    (skk-isearch-mode-cleanup)))

(add-hook 'isearch-mode-hook #'skk-isearch-setup-maybe)
(add-hook 'isearch-mode-end-hook #'skk-isearch-cleanup-maybe)
------------------------------------------------------------------------

50ddskk-gentoo.el is based on, but not identical to, skk-setup.el. I think this fix is sufficient. I don't know how to write a version dependent SITEFILE.

[1] Ref: READMEs/NEWS.ja (in source tarball, written in Japanase) Search for the words "14.4" and see the first heading. The change was done in git commit 319705. Git repository is https://github.com/skk-dev/ddskk, as you can see from http://openlab.jp/skk/index-j.html

** Other update info
ddskk < 15.2 rely on obsolete functions, and do not work under Emacs-24.4. These functions are `isearch-other-control-char' and `isearch-other-meta-char'

Thanks.


Reproducible: Always
Comment 1 Teika kazura 2015-04-03 01:01:52 UTC 
Created attachment 400442 [details]
ddskk-15.2.ebuild