Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545328 - app-emulation/xen-tools - ovmf, seabios SRC_URI should be USE-conditional
Summary: app-emulation/xen-tools - ovmf, seabios SRC_URI should be USE-conditional
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Xen Devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 13:11 UTC by Alex Xu (Hello71)
Modified: 2015-04-03 05:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Xu (Hello71) 2015-04-02 13:11:56 UTC
afaict the seabios distfile is only required on arm or !system-seabios; similar for ovmf.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2015-04-02 15:05:40 UTC
seabios distfile is only required on arm.

Hmm, well I' curious to see what dlan has to say on this.  He has been working arm hardware lately and is familiar with the layout. Aside from that I spent around 4 months solid last year getting arm keyworded and this rather suggests I missed something completely, unless this has changed in recent versions.
Comment 2 Alex Xu (Hello71) 2015-04-02 16:00:31 UTC
Note: I didn't actually test bypassing the unpack; this is just what I think based on the ebuild.
Comment 3 Alex Xu (Hello71) 2015-04-02 16:08:44 UTC
Huh, looks like the dep changed from !arm to amd64. I will test disabling the unpack later today.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2015-04-03 05:33:38 UTC
 ovmf, seabios SRC_URI should be USE-conditional
is to dictate (to us) what it SHOULD be.
The use of the word should carries so much baggage. dlan and I have worked these ebuilds extensively long ago.  The choice of whether to use a use flag is an arbitrary one we made then.  There are comments by long standing devs in the ML threads and bugs that query the merit of making patches or fetching of tarballs conditional on a use flag. There was never a clear cut case for either state to be 'right' or 'best'.

You should not tell us what the final form should be.
From dlan; not simply adjust SRC_URI, also will touch ebuild (patch, configure)

which says the form of the ebuild is fine as is.  He also plans to look at (patch, configure) but let's let him expand on that in his own time.

I added arm support to xen just under a year ago with full support and input from  dlan.  We did not do so without routine intensive testing and editing.

Test as you will