Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545288 - app-i18n/man-pages-pl version bump request
Summary: app-i18n/man-pages-pl version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Marcin Kowalski
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 07:49 UTC by Marcin Kowalski
Modified: 2015-08-12 12:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
man-pages-pl-0.6.ebuild (man-pages-pl-0.6.ebuild,853 bytes, text/plain)
2015-04-21 18:25 UTC, Marcin Kowalski
Details
work in progress ebuild (man-pages-pl-0.6.ebuild,843 bytes, text/plain)
2015-07-28 16:44 UTC, Marcin Kowalski
Details
wip ebuild v2 (man-pages-pl-0.6.ebuild,649 bytes, text/plain)
2015-07-29 18:53 UTC, Marcin Kowalski
Details
ebuild with minor eapi=5 update (man-pages-pl-0.6.ebuild,649 bytes, text/plain)
2015-08-06 19:48 UTC, Marcin Kowalski
Details
update copyright year, drop blank IUSE (man-pages-pl-0.6.ebuild,641 bytes, text/plain)
2015-08-12 07:11 UTC, Marcin Kowalski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Kowalski 2015-04-02 07:49:20 UTC
Original website for man-pages-pl is obsolete and nonfunctional.

Please change the ebuild to instead pull from the project at http://sourceforge.net/projects/manpages-pl/?source=navbar , which is actively maintained.
Comment 1 Marcin Kowalski 2015-04-21 18:25:56 UTC
Created attachment 401756 [details]
man-pages-pl-0.6.ebuild

Initial ebuild that works. Seems that most hacks from original ebuild are not necessary.
Comment 2 Pacho Ramos gentoo-dev 2015-04-21 18:53:58 UTC
Are you willing to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

Thanks
Comment 3 Marcin Kowalski 2015-07-24 11:46:28 UTC
Sorry for late reply - yes, i can proxy maintain this package.
Comment 4 Pacho Ramos gentoo-dev 2015-07-25 09:18:55 UTC
CCing proxy-maintainers then

Thanks
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-07-28 11:17:19 UTC
Before resetting metadata.xml and entering you as proxy;

1. KEYWORDS="alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 s390 sh sparc x86"
need resetting to ~ state

2. DOCS=(AUTHORS ChangeLog FAQ NEWS README TODO)
is copy pasted from the old ebuild. Not all these files are not present and draw error.

3. The sed stmnt of rc_prepare() is commented out. Does it belong or not?

Once these points have been addressed, an updated ebuild attached which works on run testing, you will qualify to have yourself entered as the proxy maintainer and the ebuild added to portage.

Also there is a notable absence of code equivalent to the previous version.  Can you assure the mew version makes these unrequired?
Comment 6 Marcin Kowalski 2015-07-28 16:43:47 UTC
(In reply to Ian Delaney from comment #5)
> Before resetting metadata.xml and entering you as proxy;
> 
> 1. KEYWORDS="alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 s390 sh
> sparc x86"
> need resetting to ~ state
> 
> 2. DOCS=(AUTHORS ChangeLog FAQ NEWS README TODO)
> is copy pasted from the old ebuild. Not all these files are not present and
> draw error.
> 
> 3. The sed stmnt of rc_prepare() is commented out. Does it belong or not?
> 
> Once these points have been addressed, an updated ebuild attached which
> works on run testing, you will qualify to have yourself entered as the proxy
> maintainer and the ebuild added to portage.
> 
> Also there is a notable absence of code equivalent to the previous version. 
> Can you assure the mew version makes these unrequired?

I'm working through the duplicated manpages, as it seems at least vim-core provides its own polish manpages. There are no file collisions, though as vim installs to /usr/share/man/pl.UTF-8 and man-pages-pl to /usr/share/man/pl/

The sed command seems unnecessary, i fixed up the DOCS and KEYWORDS for now and will have to go through the potential duplicate manpages.
Comment 7 Marcin Kowalski 2015-07-28 16:44:47 UTC
Created attachment 407816 [details]
work in progress ebuild
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2015-07-29 01:06:55 UTC
Good. A couple more.

1. EAPI=4; We're on the verge of EAPI 6 let alone leave out EAPI 5 

2.
DOCS=(AUTHORS README )  -> DOCS=( AUTHORS README ). Personally I think the AUTHORS is waste of space, but meh.

3. If there are no deps at all, both RDEPEND and DEPEND are superfluous and should be deleted. Te simply make for cruft.

4. The src_prepare() still needs taking out.

Otherwise doing well.
Comment 9 Marcin Kowalski 2015-07-29 06:17:47 UTC
Ok, i'll get to it later today. 

Still not certain how to tackle the potential manpage conflicts. Are there perhaps listings of package contents online? 

I recall website somewhere, but i am not sure if it also tracked manpage files or how up to date it was.
Comment 10 Marcin Kowalski 2015-07-29 18:53:10 UTC
Created attachment 407950 [details]
wip ebuild v2

Now i have to figure out potential duplicates.
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2015-07-30 10:08:37 UTC
(In reply to Marcin Kowalski from comment #9)
> Ok, i'll get to it later today. 
> 
> Still not certain how to tackle the potential manpage conflicts. Are there
> perhaps listings of package contents online? 
> 

Not sure what you mean. Do you not mean the source repo?

Still need to set EAPI to 5
Comment 12 Marcin Kowalski 2015-08-05 07:47:31 UTC
The old ebuild deleted some manpages prior to install, as it seemed more up to date ones were provided by native packages.

So i am looking for a way to get a list of packages with up to date localised manpages so that i can strip them out of this package to avoid duplication.
Comment 13 Marcin Kowalski 2015-08-06 19:48:09 UTC
Created attachment 408424 [details]
ebuild with minor eapi=5 update

small update with eapi=5
Comment 14 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2015-08-06 20:32:13 UTC
(In reply to Marcin Kowalski from comment #13)
> Created attachment 408424 [details]
> ebuild with minor eapi=5 update
> 
> small update with eapi=5

fix years in header and also you can drop empty IUSE with because of EAPI=5
Comment 15 Marcin Kowalski 2015-08-12 07:11:37 UTC
Created attachment 408838 [details]
update copyright year, drop blank IUSE

updates per suggestions.