Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544896 - =/sci-mathematics/p9m4-05 request for conversion to new EAPI & eclass
Summary: =/sci-mathematics/p9m4-05 request for conversion to new EAPI & eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2015-04-12
Assignee: Mark Wright
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-29 06:24 UTC by Ian Delaney (RETIRED)
Modified: 2015-05-08 08:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-03-29 06:24:49 UTC
p9m4-05.ebuild inherit distutils and require conversion to the new eclass and EAPI upgrade.  Normally I supply the patch but there is something odd in the setup with the patches in this ebuild but that simply doesn't work with switching inherit base distutils to inherit base distutils-r1, and it's source is the presence of base eclass. In

PATCHES=("${DISTDIR}/${MY_PN}05-64bit.patch.bz2"

there is normally a space between and PATCHES=( AND "
it is patching a tarred file directly from $DISTDIR

this in fact works, not once but twice.  In summary, the ebuild has 2 src_prepare phases invoked.  In the -r1, the eclass duplicates the PATCHES var and it attempts to run epatch all patches a 2nd time, which ofcourse fails.  I have spent long enough figuring that far, you 'may' re-write a revbump to accommodate the new eclass with this info.  This is the 1st. occasion this feature of the -r1 eclass has 'backfired' in this fashion.

Usual style to convert an ebuild of this type is to set:

EAPI=5

PYTHON_COMPAT=( python2_7 )
DISTUTILS_SINGLE_IMPL=1

inherit distutils-r1
and addition of [${PYTHON_USEDEP} to deps of dev-python and addition of 

pkg_setup() {
        python-single-r1_pkg_setup
}

The combo of DISTUTILS_SINGLE_IMPL=1 + the pkg_setup are in fact optional and can safely be discarded, or deselected.  I have done many other conversions using these so it would offer consistency across ebuilds, fwiw.
Please proceed.
Comment 1 Mark Wright gentoo-dev 2015-05-01 12:21:48 UTC
Thanks, committed, will close later if no one sees any problems or
suggests any improvements:

EAPI=5. Use python 2.7. Thanks to Ian Delaney for helping to upgrade to distutils-r1, fixes bug 544896 =/sci-mathematics/p9m4-05 request for conversion to new EAPI & eclass.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2015-05-01 13:19:37 UTC
Oh; the norm is to revbump with the change of eclass, decided in the early stages of the making of the new eclasses; for consistency
Comment 3 Mark Wright gentoo-dev 2015-05-01 14:18:21 UTC
(In reply to Ian Delaney from comment #2)
Yes, I skipped it earlier as it appeared to be broken since it had a dependency
on dev-lang/python-2.5. Done for consistency though, thanks for reviewing:
Committed:
Thanks to Ian Delaney for reviewing: the norm is to revbump with the change of eclass, decided in the early stages of the making of the new eclasses; for consistency