Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544706 - Add --autounmask-comments so Portage simply writes mask changes without comment text
Summary: Add --autounmask-comments so Portage simply writes mask changes without comme...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-27 23:20 UTC by Jacob Godserv
Modified: 2015-03-29 18:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Suggested patch (0001-Add-autounmask-comments-so-Portage-simply-writes-mas.patch,5.23 KB, patch)
2015-03-27 23:20 UTC, Jacob Godserv
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Godserv 2015-03-27 23:20:32 UTC
Created attachment 399912 [details, diff]
Suggested patch

Often, the user has their own comments they want to write, and deleting these by hand after portage has written them, especially when there are many changes, can be mildly frustrating. This patch allows the user to turn off those comments, with the idea they will write their own, or don't require comments at all.
Comment 1 Alexander Berntsen (RETIRED) gentoo-dev 2015-03-28 14:48:49 UTC
I think implementing autounmask-no-comments or whatever would be better. Simply because people hate us whenever we make even the tiniest UI change, or if we change the defaults.

The idea is OK. Though I can't help but feel this is something that should be handled generically -- i.e. not through an option specific to autounmask.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-28 14:52:33 UTC
And we should finally add a proper configuration file to Portage rather than fiddling randomly with env-vars and command-line options.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2015-03-28 15:17:56 UTC
Yes, I agree about needing a config file.  There are far too many things being set in make.conf as an environment variable.

And there are already too many options for people to remember even half of them.

Zac, you mentioned a yaml style config in irc?  Why, emerge already uses configparser for repos.conf parsing.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-28 15:23:18 UTC
Yes, we should just reuse the .ini-like style used for repos.conf.
Comment 5 Zac Medico gentoo-dev 2015-03-29 06:24:39 UTC
Yeah, ini style sounds good. We could make it a directory located at '/etc/portage/config.d', with files processed using the _recursive_file_list function that is used for other config files.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-03-29 15:05:18 UTC
I'd rather not move from current scheme and just do /etc/portage/portage.conf that can be a directory :).
Comment 7 Brian Dolbec (RETIRED) gentoo-dev 2015-03-29 15:59:30 UTC
Yeah, I prefer portage.conf
Comment 8 Zac Medico gentoo-dev 2015-03-29 18:02:29 UTC
In the config file, how about if we express the autounmask comment configuration like this:

[autounmask]
comment.parents.max = 0

So 0 parents makes the comment disappear entirely, but you can set the parents max to any number you want.