Created attachment 399912 [details, diff] Suggested patch Often, the user has their own comments they want to write, and deleting these by hand after portage has written them, especially when there are many changes, can be mildly frustrating. This patch allows the user to turn off those comments, with the idea they will write their own, or don't require comments at all.
I think implementing autounmask-no-comments or whatever would be better. Simply because people hate us whenever we make even the tiniest UI change, or if we change the defaults. The idea is OK. Though I can't help but feel this is something that should be handled generically -- i.e. not through an option specific to autounmask.
And we should finally add a proper configuration file to Portage rather than fiddling randomly with env-vars and command-line options.
Yes, I agree about needing a config file. There are far too many things being set in make.conf as an environment variable. And there are already too many options for people to remember even half of them. Zac, you mentioned a yaml style config in irc? Why, emerge already uses configparser for repos.conf parsing.
Yes, we should just reuse the .ini-like style used for repos.conf.
Yeah, ini style sounds good. We could make it a directory located at '/etc/portage/config.d', with files processed using the _recursive_file_list function that is used for other config files.
I'd rather not move from current scheme and just do /etc/portage/portage.conf that can be a directory :).
Yeah, I prefer portage.conf
In the config file, how about if we express the autounmask comment configuration like this: [autounmask] comment.parents.max = 0 So 0 parents makes the comment disappear entirely, but you can set the parents max to any number you want.