Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544490 - app-admin/syslog-ng-3.6.2 has sys-apps/util-linux (libuuid) automagic
Summary: app-admin/syslog-ng-3.6.2 has sys-apps/util-linux (libuuid) automagic
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-25 17:48 UTC by Nikoli
Modified: 2024-03-03 22:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2015-03-25 17:48:07 UTC
$ check-deps.sh app-admin/syslog-ng
 * Checking "app-admin/syslog-ng-3.6.2"
 * Missing in RDEPEND and DEPEND:
        sys-apps/util-linux
                X86_64;libuuid.so.1
                        /usr/lib64/libsyslog-ng-3.6.so.0.0.0

syslog-ng-3.6.2 $ grep -i uuid configure.ac 
PKG_CHECK_MODULES(UUID, uuid, enable_libuuid="yes", enable_libuuid="no")
AC_DEFINE_UNQUOTED(ENABLE_LIBUUID, `enable_value $enable_libuuid`, [Enable libuuid support])
AC_SUBST(UUID_CFLAGS)
AC_SUBST(UUID_LIBS)
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2015-03-25 18:05:19 UTC
sys-apps/util-linux is in the system set for linux systems.
Comment 2 Nikoli 2015-03-25 18:16:53 UTC
Yes, now it is. But it is safer to have it in deps explicitly. And it is common practise, look at 'qgrep -N sys-apps/util-linux'.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2015-03-25 18:33:30 UTC
You haven't made a convincing argument.  Safety isn't really an issue and what other packages do isn't necessarily relevant since there are many different reasons those packages are listing util-linux explicitly.  If you sent a patch upstream making uuid support optional I would put util-linux behind a use flag but as the package currently exists I'm not leaning toward changing the deps.
Comment 4 Nikoli 2015-03-25 19:07:26 UTC
Indeed without '--disable-uuid / --enable-uuid' or similar ./configure option it is hardly possible to have uuid USE flag. Having non optional sys-apps/util-linux dep is wrong, because it is masked in several profiles.
Comment 5 SpanKY gentoo-dev 2015-05-04 03:22:42 UTC
we do require people to depend on util-linux for the libraries it installs (in this case, libuuid).  respecting the USE=uuid flag is even better (and looks like it should be somewhat possible).