Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544046 - net-wireless/hostapd split drivers and ssl
Summary: net-wireless/hostapd split drivers and ssl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Andriy Utkin (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2015-03-21 18:42 UTC by Conrad Kostecki
Modified: 2018-04-27 21:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
hostapd-2.4-variant1.ebuild (hostapd-2.4-variant1.ebuild,6.03 KB, text/plain)
2015-03-21 18:42 UTC, Conrad Kostecki
Details
hostapd-2.4-variant1.diff (hostapd-2.4-variant1.diff,2.73 KB, patch)
2015-03-21 18:42 UTC, Conrad Kostecki
Details | Diff
hostapd-2.4-variant2.diff (hostapd-2.4-variant2.diff,2.37 KB, patch)
2015-03-21 18:43 UTC, Conrad Kostecki
Details | Diff
hostapd-2.4-variant2.ebuild (hostapd-2.4-variant2.ebuild,5.67 KB, text/plain)
2015-03-21 18:43 UTC, Conrad Kostecki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2015-03-21 18:42:22 UTC
Hi!
Currently, the drivers and SSL-lib cannot be choosen by an user.
The eBuild is including everything.

Currently, that drivers are being build:
CONFIG_DRIVER_HOSTAP
CONFIG_DRIVER_NL80211
CONFIG_DRIVER_NONE
CONFIG_DRIVER_WIRED

There is also CONFIG_DRIVER_PRISM54 enabled. That one should be removed in every case! It has been long time ago removed:
2010-01-16 - v0.7.1
* remove obsolte Prism54.org driver wrapper

Most users today won't need anything than nl80211, as most wifi cards are using that.

Regarding SSL, currently we do not set any option, which means, a default fallback is made to openssl. I think, it would make sense, if we also allow to use gnutls or the internal tlsv1 implementation (but that one is experimental).
This can be controlled by CONFIG_TLS. Valid values are openssl (default), gnutls or internal.

-> wpa_supplicant has already gnutls support.

I would see two options, which I propose, how to enable this.

1) add USE_EXPAND variables.
But this means, the gentoo profile? for my understanding needs to be updated, before that eBuild can be used.
So a user has to add the following variables to make.conf
HOSTAPD_DRIVERS="nl80211" (hostap, NL80211, none, wired)
HOSTAPD_SSL="openssl" (gnutls, internal, openssl)

2) Add use flags
That solution would be more easy, as we don't have to modify the gentoo portage.
We could make use flag ssl, which is internal openssl and add gnutls/internal (wpa_supplicant has a gnutls use flag!) use flags.
And also add use flags for the drivers. For compatibility reasons, I've used the use flag ssl for openssl. Maybe this should be renamed to openssl..

I will attach a diff for both cases.

Cheers
Conrad

Reproducible: Always
Comment 1 Conrad Kostecki gentoo-dev 2015-03-21 18:42:46 UTC
Created attachment 399394 [details]
hostapd-2.4-variant1.ebuild
Comment 2 Conrad Kostecki gentoo-dev 2015-03-21 18:42:57 UTC
Created attachment 399396 [details, diff]
hostapd-2.4-variant1.diff
Comment 3 Conrad Kostecki gentoo-dev 2015-03-21 18:43:13 UTC
Created attachment 399398 [details, diff]
hostapd-2.4-variant2.diff
Comment 4 Conrad Kostecki gentoo-dev 2015-03-21 18:43:25 UTC
Created attachment 399400 [details]
hostapd-2.4-variant2.ebuild
Comment 5 Andriy Utkin (RETIRED) gentoo-dev 2018-03-30 16:59:59 UTC
Will look into the ticket soon. Have not read it yet.
Comment 6 Andriy Utkin (RETIRED) gentoo-dev 2018-04-12 00:56:03 UTC
> Currently, the drivers and SSL-lib cannot be choosen by an user.

Recently I added "savedconfig" support so now you can choose your drivers.

"ssl" USE flag will be removed, and a choice between openssl, libressl and gnutls will be provided. I am working on this now, stay tuned.

> Most users today won't need anything than nl80211, as most wifi cards are using that.

I will look into adding a "minimal" use flag later.
Comment 7 Conrad Kostecki gentoo-dev 2018-04-12 10:38:14 UTC
Hi Andrey,
thanks for taking this up! :)

I think, as you have now implemented "savedconfig", this ticket can be closed.

But I don't think, a minimal use flag makes sense, as nl80211 will be configured via savedconfig?

Conrad
Comment 8 Andriy Utkin (RETIRED) gentoo-dev 2018-04-27 21:35:42 UTC
> There is also CONFIG_DRIVER_PRISM54 enabled.

This has been addressed.
Still working on adding more TLS implementation options to the ebuild.
Thanks for the report. I think at this point I can close it.