Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54377 - (PATCH) libmpeg3 doesn't build if ROOT is not "/"
Summary: (PATCH) libmpeg3 doesn't build if ROOT is not "/"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-18 18:42 UTC by devsk
Modified: 2004-09-30 06:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
include -L${ROOT}usr/lib before -la52 (patch,767 bytes, patch)
2004-06-18 18:43 UTC, devsk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description devsk 2004-06-18 18:42:21 UTC
emerge of libmpeg3 fails because ebuild sed's to include -la52 ( a bad thing to do...just kidding..:)) but then forgets to include -L${ROOT}usr/lib before it. This patch corrects it. Please include it in next ebuild.

Reproducible: Always
Steps to Reproduce:
1. emerge libmpeg3
2.
3.

Actual Results:  
fails to install

Expected Results:  
It should install

patch:

--- libmpeg3-1.5.2.ebuild.ORG   2004-06-18 18:41:04.000000000 -0700
+++ libmpeg3-1.5.2.ebuild       2004-05-29 13:06:39.000000000 -0700
@@ -1,6 +1,6 @@
 # Copyright 1999-2004 Gentoo Technologies, Inc.
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/libmpeg3/libmpeg3-1.5.2.ebuild,v
1.8 2004/05/16 19:48:57 vapier Exp $
+# $Header: /home/cvsroot/gentoo-x86/media-libs/libmpeg3/libmpeg3-1.5.2.ebuild,v
1.8 2004/05/16 19:48:57 vapier Exp $
 
 inherit flag-o-matic eutils gcc
 
@@ -37,7 +37,7 @@
        echo > Makefile.a52
        rm -rf a52dec-0.7.3/*
        ln -s /usr/include/a52dec a52dec-0.7.3/include
-       sed -i '/LIBS = /s:$: -la52:' Makefile
+       sed -i '/LIBS = /s:$: -L${ROOT}usr/lib -la52:' Makefile
 }
 
 src_compile() {
Comment 1 devsk 2004-06-18 18:43:40 UTC
Created attachment 33542 [details, diff]
include -L${ROOT}usr/lib before -la52
Comment 2 Gergan Penkov 2004-09-30 06:08:12 UTC
when one has djbfft in his use flags the libmpeg3 fails to compile with 
//usr/lib/liba52.a(imdct.o)(.text+0x12db): In function `a52_imdct_init':
: undefined reference to `fftc4_un128'
//usr/lib/liba52.a(imdct.o)(.text+0x12e1): In function `a52_imdct_init':
: undefined reference to `fftc4_un64'
i have resolve this with the simple addition of -ldjbfft to the patch 
so the line reads :
sed -i '/LIBS = /s:$: -L${ROOT}usr/lib -la52 -ldjbfft:' Makefile
But this is only a temporary solution, because the ebuild must check whether the flag ist or not.
Comment 3 Patrick Kursawe (RETIRED) gentoo-dev 2004-09-30 06:49:21 UTC
Checking the flag won't help here - it matters if liba52 was compiled with or without djbfft. I've put a fix into portage, please test when it hits your mirror. Works for me.