Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543518 - media-video/libav-11.3: seems CFLAGS are not respected when USE neon is enabled
Summary: media-video/libav-11.3: seems CFLAGS are not respected when USE neon is enabled
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 541664
  Show dependency tree
 
Reported: 2015-03-16 15:51 UTC by Nikoli
Modified: 2015-06-24 15:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for libav-11.3.ebuild (0001-libav-respect-CFLAGS-when-USE-neon-is-enabled.patch,974 bytes, patch)
2015-03-16 15:51 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2015-03-16 15:51:37 UTC
Created attachment 399038 [details, diff]
patch for libav-11.3.ebuild

Possible regression was introduced in commit http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/libav/libav-9999.ebuild?r1=1.21&r2=1.22

Ebuild uses --extra-cflags="${CFLAGS}" to set CFLAGS, but --extra-cflags=-mfpu=neon seems to override it. I do not have arm device, so i can not test attached patch. Arm team, please help.
Comment 1 Nikoli 2015-03-17 20:29:17 UTC
libav-11.3.ebuild,v 1.4 has the patch.
Comment 2 Pacho Ramos gentoo-dev 2015-04-30 10:41:30 UTC
I am not sure if this bug should still be opened or, at least, keep blocking the stabilization one as the ebuild is fixed (but still waiting for arm testing... but, anyway, arm team will need to test it again for stabilization)
Comment 3 Alexander Tsoy 2015-05-27 09:47:36 UTC
I suggest replacing --extra-cflags="${CFLAGS}" with --disable-optimizations and dropping "use neon && myconf+=( --extra-cflags=-mfpu=neon )" completely. This works perfectly with libvpx (see bug 547194).
Comment 4 Alexander Tsoy 2015-05-27 09:58:40 UTC
--disable-optimizations will prevent build system from passing -O3 to compiler (I guess this was the reason for --extra-cflags="${CFLAGS}"). -mfpu=neon will be passed by the build system where needed. I'll test these changes when I have time and attach patch here.
Comment 5 Alexander Tsoy 2015-05-27 13:44:10 UTC
Hmm. It seems libav is different. It's build system doesn't have a switch to enable neon (only to disable). Instead if -mfpu=neon is in CFLAGS then neon intrinsics are enabled automatically. So please ignore my previous comments. :)

BTW the patch was already applied, so the bug can be closed.
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/libav/libav-11.3.ebuild?r1=1.3&r2=1.4