Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543100 - app-shells/bash-completion escape character breaks completion
Summary: app-shells/bash-completion escape character breaks completion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
: 561682 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-13 00:35 UTC by Bob Wya
Modified: 2017-01-01 13:18 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bash-completion-2.1-r91-bash-4.3.patch (bash-completion-2.1-r91-bash-4.3.patch,1.02 KB, patch)
2015-03-13 00:41 UTC, Bob Wya
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Wya 2015-03-13 00:35:00 UTC
All recent builds of the app-shells/bash-completion do not correctly handle \ escape characters. Due to usual BASH problems of needing a \\ sequence to mangle down to \.




Reproducible: Always

Steps to Reproduce:
1. mkdir -p ~/"test test/test test"
2. type cd ~/test
3. attempt tab completion of path
Actual Results:  
Tab completion will fail at the first space character. User will be unable to complete the full path.

Expected Results:  
As the path is (presumably) unique - it should be fully tab completable.

This is fixed in the Upstream git tree master.
Comment 1 Bob Wya 2015-03-13 00:41:24 UTC
Created attachment 398770 [details, diff]
bash-completion-2.1-r91-bash-4.3.patch

I've tested this patch and it applies cleanly to:
app-shells/bash-completion-2.1_p20141224.ebuild
app-shells/bash-completion-2.1-r91.ebuild
app-shells/bash-completion-2.1-r92.ebuild
app-shells/bash-completion-2.1-r93.ebuild

Not required for:
app-shells/bash-completion-9999.ebuild
(it's now merged)

I've not tested it on:
<app-shells/bash-completion-2.1-r91.ebuild


The patch is from the ARCH bash-completion package - here...
https://projects.archlinux.org/svntogit/packages.git/plain/trunk/bash-4.3.patch?h=packages/bash-completion


I've added patched ebuilds to my layman overlay:
https://github.com/bobwya/bobwya/tree/master/app-shells/bash-completion
Comment 2 Bailey Kong 2015-08-06 20:35:48 UTC
Can confirm that applying the patch to 2.1_p20141224 fixes the problem for me. Thanks Bob Wya.
Comment 3 Christophe PEREZ 2015-08-18 17:09:31 UTC
Confirmed for me too (bug and patch)
Comment 4 MaurizioB 2016-01-10 20:48:55 UTC
The patch works for me too, and solves the bug.
Comment 5 Patrice Clement gentoo-dev 2016-01-10 21:07:24 UTC
commit 5ba926b (HEAD, master)
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Sun Jan 10 21:05:57 2016 +0000

    app-shells/bash-completion: Add patch to fix completion with escape characters. Fixes bug 543100.
    
    Package-Manager: portage-2.2.26
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 create mode 100644 app-shells/bash-completion/bash-completion-2.1-r94.ebuild
 create mode 100644 app-shells/bash-completion/files/bash-completion-2.1-escape-characters.patch
Comment 6 Coacher 2016-01-11 07:48:33 UTC
(In reply to Bob Wya from comment #0)
> This is fixed in the Upstream git tree master.

This patch is not included in the latest upstream git master as of 9cbd68becbd728d5fda88a6f456c4c72eac92ec8. Could you please file a bug report upstream and make it happen?
Comment 7 Patrice Clement gentoo-dev 2016-01-11 08:13:23 UTC
*** Bug 561682 has been marked as a duplicate of this bug. ***
Comment 8 Louis Sautier (sbraz) gentoo-dev 2016-01-28 13:52:18 UTC
Reported upstream: https://alioth.debian.org/tracker/index.php?func=detail&aid=315291&group_id=100114&atid=413095
An account is required to view it though…
Comment 9 Bob Wya 2016-01-28 15:25:50 UTC
(In reply to Louis Sautier from comment #8)
> Reported upstream ...

Thanks :-)