542848 – games-board/crafty-24.1 fails to build for ppc hardware

Bug 542848 - games-board/crafty-24.1 fails to build for ppc hardware

Summary: games-board/crafty-24.1 fails to build for ppc hardware

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	PPC Linux

Importance:	Normal normal
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-03-10 20:24 UTC by Thomas Juerges
Modified:	2015-05-16 00:05 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log. (build.log,9.20 KB, text/x-log) 2015-03-10 20:24 UTC, Thomas Juerges	Details
Patch for ppc compilation. (crafty-24.1-locking_on_foreign_platforms.patch,1.53 KB, patch) 2015-03-10 20:25 UTC, Thomas Juerges	Details \| Diff
New ebuild for crafty (crafty-24.1-r1.ebuild,2.53 KB, text/plain) 2015-03-10 20:25 UTC, Thomas Juerges	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Juerges 2015-03-10 20:24:16 UTC

Created attachment 398630 [details]
Build log.

Crafty 24.1 fails to build for ppc because the file lock.h lacks a dummy #define for the Pause() function in the non-SMP section.  I guess that the build would also fail for any other single CPU system.  Please see the attached build log.

I have attached a patch with a corresponding new ebuild file that allows crafty 24.1 to be built for ppc.  The patch also fixes a problem where the system is a Linux/Unix system but the target hardware is not x86/amd64.  My modifications probably need some refinement for multi-cpu PPC/x86/amd64 but at least this should get us going.

Comment 1 Thomas Juerges 2015-03-10 20:25:00 UTC

Created attachment 398632 [details, diff]
Patch for ppc compilation.

Comment 2 Thomas Juerges 2015-03-10 20:25:45 UTC

Created attachment 398634 [details]
New ebuild for crafty

Comment 3 Mr. Bones. (RETIRED) gentoo-dev

2015-05-16 00:05:37 UTC

Also with USE=no-opts.  I guess no one uses that flag.

In portage; thanks for the bug report and patch.