Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 542072 - x11-misc/quitcount New package request
Summary: x11-misc/quitcount New package request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Laurent V
URL: http://quitcount.sourceforge.net/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2015-03-04 11:15 UTC by Laurent V
Modified: 2015-12-15 06:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
quitcount-3.1.3.ebuild (quitcount-3.1.3.ebuild,596 bytes, text/plain)
2015-03-04 11:15 UTC, Laurent V
Details
emerge --info (emerge-info,4.71 KB, text/plain)
2015-03-04 11:16 UTC, Laurent V
Details
Updated ebuild (quitcount-3.1.3.ebuild,606 bytes, text/plain)
2015-04-23 07:27 UTC, Laurent V
Details
quitcount-3.1.3.ebuild (updated 08/12/2015) (quitcount-3.1.3.ebuild,575 bytes, text/plain)
2015-12-08 08:38 UTC, Laurent V
Details
quitcount-3.1.3.ebuild (fixed) (quitcount-3.1.3.ebuild,561 bytes, text/plain)
2015-12-10 13:38 UTC, Laurent V
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent V 2015-03-04 11:15:29 UTC
Created attachment 398018 [details]
quitcount-3.1.3.ebuild

Hi !

I've made an ebuild for the quitcount application which is a tiny system tray applet to keep track of how many days you've spend away from smoking as well as money saved and other variables.

The ebuild works fine and the application runs flawlessly but I'm still unsure about the DEPEND/RDEPEND part (newbie ebuild writer here), I've used scanelf to inspect to binary and I've put what I thought would be the proper variables.

Please let me know if I need to fix something, I'm willing to finish my work on it :) 

Have a nice day !
Comment 1 Laurent V 2015-03-04 11:16:14 UTC
Created attachment 398020 [details]
emerge --info
Comment 2 Laurent V 2015-04-23 07:27:42 UTC
Created attachment 401856 [details]
Updated ebuild

Updated ebuild to remove unneeded dependencies
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-12-05 09:06:22 UTC
This is close to standard. Requires:

1. The ebuild requires a version in its name. The ebuild indicate vn. 3.1 but there is a choice of 3 minor vns. I have tested on the most recent; 
quitcount-3.1.3.ebuild

2. http://sourceforge.net/projects/quitcount/files/quitcount/3.1/${P}.tar.gz is odd since it doesn't correspond to the normal conventions. In ebuild writing it is convention to do something like;

MV="3.1"
SRC_URI="mirror://sourceforge/${PN}/${MV}/${P}.tar.gz".
There is more than one right way here.

3. while pkg_postinst() { gtk-update-icon-cache; } works, it is better form to use the eclass to call gtk-update-icon-cache, in this case gnome2-utils.

For a sample ebuild, see media-video/mpv/mpv-0.11.0.ebuild.
Otherwise, I get the ebuild with above changes to build and install
Comment 4 Laurent V 2015-12-08 08:37:44 UTC
Hi Ian !

A warm thanks for your time on this bug report, your explanation was very clear, this is helpful and really appreciated !

I did the needed changes on the ebuild, I think we're pretty close to what it should look like.

Laurent
Comment 5 Laurent V 2015-12-08 08:38:56 UTC
Created attachment 418750 [details]
quitcount-3.1.3.ebuild (updated 08/12/2015)
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-12-09 15:29:49 UTC
looks fine. Well done. Will likely add tomorrow.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2015-12-10 11:00:40 UTC
DESCRIPTION  is generally kept <= 80 chars, and also is meant not to contain the name of its own package. This crosses both rules.

Also re-position MV="3.1" to be before DESCRIPTION.
Rest looks fine
Comment 8 Laurent V 2015-12-10 13:38:51 UTC
Created attachment 418938 [details]
quitcount-3.1.3.ebuild (fixed)

Hi Ian,

Thank you for your feedback !

Here's the updated version, fixing the two errors listed above.

Kind regards, 

Laurent
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2015-12-15 06:15:53 UTC
commit 508f2577f3ebf0bf400302746bac89242878a287
Author: Ian Delaney <idella4@gentoo.org>
Date:   Tue Dec 15 14:14:22 2015 +0800

    x11-misc/quitcount: New ebuild submitted via buzilla bug #542072
    
    A tiny system tray applet, author set as proxy maintainer under the
    proxy-maintainers project, fixes the gentoo bug
    
    Gentoo bug: #542072