Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 542024 - webapp.eclass: reduce webapp_serverowned() verbosity
Summary: webapp.eclass: reduce webapp_serverowned() verbosity
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 16:36 UTC by Bernard Cafarelli
Modified: 2015-05-12 15:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Cafarelli gentoo-dev 2015-03-03 16:36:01 UTC
Detailed output from webapp_serverowned (especially with -R) can be quite noisy with modern webapps, has limited use, and reduces the log readability

For example, www-apps/owncloud has a bundle of applications (outside the core) delivered with the standard tarball, which amount to 6000 files (more like 4800
with 8.0, but still), which imply the same amount of elog lines from this install line:
webapp_serverowned -R "${MY_HTDOCSDIR}"/apps

This makes other log messages (like webapp-config output, or post-install.txt display) lost in the console buffer, or missed by the user (see #539694 for an example).

We could move the elog call to webapp_serverowned, and only log one line like "(server owned) (recursive) $@", or drop it completely?

A faster implementation for recursive mode would be nice, but that's another feature request :)
Comment 1 Anthony Basile gentoo-dev 2015-05-09 17:11:37 UTC
Just drop it.  Even that one line doesn't really give you useful info.

--- webapp.eclass.orig	2015-05-09 13:08:19.959802884 -0400
+++ webapp.eclass	2015-05-09 13:09:03.476804865 -0400
@@ -244,7 +244,6 @@
 	local my_file="$(webapp_strip_appdir "${1}")"
 	my_file="$(webapp_strip_cwd "${my_file}")"
 
-	elog "(server owned) ${my_file}"
 	echo "${my_file}" >> "${D}/${WA_SOLIST}"
 }
Comment 2 Bernard Cafarelli gentoo-dev 2015-05-12 15:15:29 UTC
Thanks, I just committed it :)