Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541576 - dev-util/universalindentgui-1.2.0-r1: support for Uncrustify indenter
Summary: dev-util/universalindentgui-1.2.0-r1: support for Uncrustify indenter
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-28 02:03 UTC by .
Modified: 2022-05-10 19:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description . 2015-02-28 02:03:50 UTC
Although UniversalIndentGUI supports 20+ backends, only a small portion of them is supported in the ebuild. I prefer Uncrustify, which is missing and thus I've patched the ebuild to support it (hope I've done it right). Patches are attached in the "Additional information" section.

Reproducible: Always




Patch for ebuild:

@@ -15,7 +15,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="debug examples html perl php python ruby xml"
+IUSE="debug examples html perl php python ruby xml uncrustify"
 
 DEPEND="dev-qt/qtcore:4
 	dev-qt/qtgui:4
@@ -34,6 +34,7 @@
 	php? ( dev-php/PEAR-PHP_Beautifier )
 	ruby? ( dev-lang/ruby )
 	xml? ( dev-util/xmlindent )
+	uncrustify? ( dev-util/uncrustify )
 "
 
 DOCS="CHANGELOG.txt readme.html"
@@ -99,6 +100,10 @@
 		UIGUIFILES="${UIGUIFILES} xmlindent"
 	fi
 
+	if use uncrustify; then
+		UIGUIFILES="${UIGUIFILES} uncrustify"
+	fi
+
 	local IFILES= I=
 	for I in ${UINDENTERS}; do
 		IFILES="${IFILES} indenters/${I}"



Patch for metadata.xml:


@@ -8,5 +8,6 @@
 	</maintainer>
 	<use>
 		<flag name="html">Add support for HTML files</flag>
+		<flag name="uncrustify">Add support for Uncrustify indenter and beautifier</flag>
 	</use>
 </pkgmetadata>
\ No newline at end of file
Comment 1 Michael Palimaka (kensington) gentoo-dev 2015-03-04 18:35:08 UTC
Given the large number of backends, I wonder if it would make sense to install all the support files unconditionally, then just add an elog advising of backend names that are packaged.
Comment 2 . 2015-03-08 12:15:17 UTC
(In reply to Michael Palimaka (kensington) from comment #1)
> Given the large number of backends, I wonder if it would make sense to
> install all the support files unconditionally, then just add an elog
> advising of backend names that are packaged.

I've just reviewed universalindentgui package in debian (https://sources.debian.net/src/universalindentgui/1.2.0-1/debian/control/) and arch (https://aur.archlinux.org/packages/universalindentgui/), and they both install full universalindentgui without backends and then recommends these backends as optional deps. So yes, it'd probably make sense.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2017-10-12 12:24:37 UTC
Package removed.