Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54156 - repoman should check for multiple inherit lines
Summary: repoman should check for multiple inherit lines
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-16 19:08 UTC by Mr. Bones. (RETIRED)
Modified: 2005-02-28 00:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mr. Bones. (RETIRED) gentoo-dev 2004-06-16 19:08:37 UTC
repoman should check for multiple inherit lines and error out in this case.

According to nick's mail "Portage Info + Status Update", ebuilds should only
call inherit once.  I fixed 41 instances of this in the portage tree.  It's
clean now, but obviously people are doing it so repoman should stop them.
Comment 1 Brian Harring (RETIRED) gentoo-dev 2004-06-16 19:48:34 UTC
This should require a modification to inherit; aside from building kludgery into ebuild.sh to enable a strict mode, might be worth looking into exporting QA complaints into portage.
Basically append QA complaints to a bash array, if in depend mode, export the QA complaints akin to how $dbkey is exported.
Comment 2 SpanKY gentoo-dev 2004-06-17 16:20:18 UTC
before this can happen something needs to be done about the conditional inherit problem

use debug && inherit debug
use python && inherit python
etc...
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-06-17 16:26:19 UTC
I think carpaski mentioned that the use handling should be moved into the eclass
in that case.
Comment 4 SpanKY gentoo-dev 2004-06-17 16:51:57 UTC
he did point that out ... then i pointed out that that just plain isnt possible in many cases
Comment 5 Brian Harring (RETIRED) gentoo-dev 2004-08-04 21:03:33 UTC
I can add a check to watch for multiple inherit calls, although it'll have to come after pre16 (it's about to go out the door).
Comment 6 Brian Harring (RETIRED) gentoo-dev 2004-08-04 21:04:40 UTC
Err, specifically, add a check to ebuild.sh throwing a QA notice about it.
At some point repoman will need to start harvesting those QA notices.
Comment 7 Brian Harring (RETIRED) gentoo-dev 2005-02-28 00:48:23 UTC
Check went out sometime >=.51_pre16 and <=.51-rc*