Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541318 - app-text/evince: Add a USE flag that pull in gvfs
Summary: app-text/evince: Add a USE flag that pull in gvfs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All All
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 08:29 UTC by Kelvin Ng
Modified: 2015-02-27 21:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kelvin Ng 2015-02-25 08:29:21 UTC
gnome-base/gvfs is needed so that features like adding bookmarks can be used. It is not pulled in if I do not use gnome as desktop environment (I use xfce4). Some people may not want this function, but some (like me) want. So, I hope that a USE flag is added to let users choose whether to pull it in or not.

I have 'neat freak' so I do not want to add it to world.
Comment 1 Pacho Ramos gentoo-dev 2015-02-25 10:00:39 UTC
Reading this:
https://git.gnome.org/browse/evince/commit/?id=6c3e1d5f5c297d0158d4bfe027a7e16cec6831bb

gvfs should be added to RDEPEND with "gnome" USE flag 

But looking to:
https://git.gnome.org/browse/evince/commit/?id=cdbc65b6566faa422bab219c0b60d30d0093eaeb

Looks like me more like an unconditional dependency
Comment 2 Kelvin Ng 2015-02-25 10:05:14 UTC
(In reply to Pacho Ramos from comment #1)
> Reading this:
> https://git.gnome.org/browse/evince/commit/
> ?id=6c3e1d5f5c297d0158d4bfe027a7e16cec6831bb
> 
> gvfs should be added to RDEPEND with "gnome" USE flag 
> 
> But looking to:
> https://git.gnome.org/browse/evince/commit/
> ?id=cdbc65b6566faa422bab219c0b60d30d0093eaeb
> 
> Looks like me more like an unconditional dependency

This is not true. I can use the bookmark function of evince with gvfs installed but **without** gnome-base/gnome-desktop installed. So, they should not be pulled in by a single USE flag.
Comment 3 Pacho Ramos gentoo-dev 2015-02-25 10:15:40 UTC
Yeah... because of the second commit is why I think it should be always pulled... but I leave there both references as there are some people that always complaint when we add a new dependency and would probably tell us that it's not needed ;)
Comment 4 Kelvin Ng 2015-02-25 11:32:40 UTC
(In reply to Pacho Ramos from comment #3)
> Yeah... because of the second commit is why I think it should be always
> pulled... but I leave there both references as there are some people that
> always complaint when we add a new dependency and would probably tell us
> that it's not needed ;)

So, what is your decision?
Comment 5 Pacho Ramos gentoo-dev 2015-02-25 11:55:48 UTC
+  25 Feb 2015; Pacho Ramos <pacho@gentoo.org> -evince-3.14.1.ebuild,
+  evince-3.14.1-r1.ebuild:
+  gvfs is used at runtime (#541318 by Kelvin Ng), drop old
+