541268 – repoman: warn about unquoted CC and YACC variables (Was: dev-libs/gobject-introspection-1.42.0-r1: quote CC and YACC)

Bug 541268 - repoman: warn about unquoted CC and YACC variables (Was: dev-libs/gobject-introspection-1.42.0-r1: quote CC and YACC)

Summary: repoman: warn about unquoted CC and YACC variables (Was: dev-libs/gobject-int...

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Repoman (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-02-24 18:03 UTC by Hristo Venev
Modified:	2022-07-12 03:18 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hristo Venev 2015-02-24 18:03:12 UTC

--- a/dev-libs/gobject-introspection/gobject-introspection-1.42.0-r1.ebuild
+++ b/dev-libs/gobject-introspection/gobject-introspection-1.42.0-r1.ebuild
@@ -62,8 +62,8 @@
 	# To prevent crosscompiling problems, bug #414105
 	gnome2_src_configure \
 		--disable-static \
-		CC=$(tc-getCC) \
-		YACC=$(type -p yacc) \
+		CC="$(tc-getCC)" \
+		YACC="$(type -p yacc)" \
 		$(use_with cairo) \
 		$(use_enable doctool)
 }

This fixes compiling when CC is not a single word. Do the same for YACC.

Reproducible: Always

Comment 1 Pacho Ramos gentoo-dev

2015-02-25 17:12:58 UTC

+  25 Feb 2015; Pacho Ramos <pacho@gentoo.org>
+  gobject-introspection-1.42.0-r1.ebuild:
+  Add missing quotes (#541268 by Hristo Venev)
+

I think we should try to have a repoman warning for CC and YACC then, otherwise it's easy to forget :/

Comment 2 Sam James archtester

2022-07-12 03:18:15 UTC

repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.