Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541186 - >=dev-libs/leveldb1.10.0-r1: USE=-snappy has no effect
Summary: >=dev-libs/leveldb1.10.0-r1: USE=-snappy has no effect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Johan Bergström
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 22:39 UTC by Luke-Jr
Modified: 2015-03-06 09:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
leveldb-1.18-r1.ebuild (leveldb-1.18-r1.ebuild,1.76 KB, text/plain)
2015-02-25 00:00 UTC, Johan Bergström
Details
leveldb-build_detect_platform.patch (leveldb-build_detect_platform.patch,455 bytes, patch)
2015-02-25 00:00 UTC, Johan Bergström
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke-Jr 2015-02-23 22:39:20 UTC
Beginning with 1.10.0, dev-libs/leveldb[-snappy] still compiles with snappy support (at least if app-arch/snappy is installed).
Comment 1 Luke-Jr 2015-02-24 00:29:53 UTC
Looks like the ability to disable snappy and tcmalloc was added by the leveldb-1.9.0-configure.patch file, which was dropped in 1.10+ for some reason.
Comment 2 Johan Bergström 2015-02-24 23:35:09 UTC
Yep, the build configure script (build_detect_platform) runs tests and adds them unconditionally should you have snappy (or tcmalloc) installed.

Suggested approach:
1. Call build_detect_platform from src_configure
2. Remove the call to it from Makefile
3. sed away -l/-D snappy/tcmalloc if not in IUSE
4. Profit

Thoughts?
Comment 3 Johan Bergström 2015-02-25 00:00:10 UTC
Created attachment 397446 [details]
leveldb-1.18-r1.ebuild

implemented my above suggestion
Comment 4 Johan Bergström 2015-02-25 00:00:47 UTC
Created attachment 397448 [details, diff]
leveldb-build_detect_platform.patch
Comment 5 SpanKY gentoo-dev 2015-03-06 09:01:07 UTC
Comment on attachment 397446 [details]
leveldb-1.18-r1.ebuild

please post diffs rather than entire files.  we can't easily review this.
Comment 6 SpanKY gentoo-dev 2015-03-06 09:12:46 UTC
should be all set now in the tree; thanks for the report!

Commit message: Fix USE=-snappy handling
http://sources.gentoo.org/dev-libs/leveldb/files/leveldb-1.18-configure.patch?rev=1.1
http://sources.gentoo.org/dev-libs/leveldb/leveldb-1.18-r1.ebuild?rev=1.1