Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 541172 - mail-client/roundcube - webapp-config displays misleading upgrade instructions
Summary: mail-client/roundcube - webapp-config displays misleading upgrade instructions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Web-apps project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 20:20 UTC by Amadeusz Żołnowski (RETIRED)
Modified: 2015-12-09 13:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
POST-UPGRADE (POST-UPGRADE,545 bytes, text/plain)
2015-03-02 12:36 UTC, Amadeusz Żołnowski (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Żołnowski (RETIRED) gentoo-dev 2015-02-23 20:20:35 UTC
webapp-config -U performs roundcube instance upgrade. After that it shows instructions which seem to be more an upgrade guide than post-upgrade instructions.

Here goes a part from "post-upgrade instructions":

=================================================================
POST-UPGRADE INSTRUCTIONS
=================================================================

UPGRADING instructions
======================

Follow these instructions if upgrading from a previous version
of Roundcube Webmail. We recommend to carefully backup the existing
installation as well as the database before going through the following steps.

Using the update script
-----------------------
There is a shell script (for unix based systems) that does the job for you.
To use it, unpack the archive of the new Roundcube version to a temporary location
(don't replace the Roundcube installation you want to update)
and cd into that directory. From there, run the following command in a shell:

  ./bin/installto.sh <TARGET-FOLDER>

For <TARGET-FOLDER> you specify the path to the Roundcube installation 
which should be updated. The update script will then copy all new files to the 
target location and check and update the configuration and database schema.
After all is done, the temporary folder with the new Roundcube files can be 
removed again.

Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2015-02-23 20:41:30 UTC
That message comes from roundcube's tarball itself.  They are displayed as part of webapp-config -U because of the ebuild does

  webapp_postupgrade_txt en UPGRADING

in src_install().  Not being familiar with roundcube, I don't know what you want changed here.  It sounds like you're saying we shouldn't display this because webapp-config already did the upgrade?

ie tell me what should change.
Comment 2 Amadeusz Żołnowski (RETIRED) gentoo-dev 2015-02-24 06:56:02 UTC
(In reply to Anthony Basile from comment #1)
> It sounds like you're saying we shouldn't display this
> because webapp-config already did the upgrade?

Exactly. Even the doc file is named "UPGRADING". It also includes some post-upgrade hints, but I am not sure if even those hints are useful after webapp-config -U. Is it possible to display only part of a file?
Comment 3 Anthony Basile gentoo-dev 2015-02-27 10:59:32 UTC
(In reply to Amadeusz Żołnowski from comment #2)
> (In reply to Anthony Basile from comment #1)
> > It sounds like you're saying we shouldn't display this
> > because webapp-config already did the upgrade?
> 
> Exactly. Even the doc file is named "UPGRADING". It also includes some
> post-upgrade hints, but I am not sure if even those hints are useful after
> webapp-config -U. Is it possible to display only part of a file?

I don't know roundcube at all.  If you want to give me a patch or suggest a change (like should I just drop the UPGRADE message?) I'll commit it.
Comment 4 Amadeusz Żołnowski (RETIRED) gentoo-dev 2015-03-02 12:36:09 UTC
Created attachment 397850 [details]
POST-UPGRADE

I have assembled instructions from UPGRADING file.
Comment 5 Aaron W. Swenson gentoo-dev 2015-12-09 13:00:36 UTC
commit c20f39cdcba8d3f75fcd7d6c09e80d2ee0655e40
Author: Aaron W. Swenson <titanofold@gentoo.org>
Date:   Wed Dec 9 07:44:37 2015 -0500

    mail-client/roundcube: Version bump, security, and bug fixes
    
    Added two use flags controlling optional dependencies to support the
    enigma and and sieverules plugins.
    
    Added REQUIRED_USE as one of postgres, mysql, or sqlite must be
    enabled. Rouncube requires a database to operate. As the ebuild uses
    this now, removed the default enable on the mysql USE flag.
    
    Added POST-UPGRADE.txt which is just a shortened version of the
    UPGRADE text from upstream.
    
    Dropped arm and ppc64 keywords as one dependency,
    dev-php/PEAR-Net_LDAP2, currently lacks matching keywords for those
    architectures.
    
    Bug: 541172, 545096, 524192, 564476, 565204, 53284
    
    Package-Manager: portage-2.2.20.1