540440 – games-simulation/openttd-1.3.3 failed to compile error: no matching function for call to ‘max(int, unsigned int)’

Bug 540440 - games-simulation/openttd-1.3.3 failed to compile error: no matching function for call to ‘max(int, unsigned int)’

Summary: games-simulation/openttd-1.3.3 failed to compile error: no matching function ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-02-18 08:37 UTC by cono
Modified:	2015-03-26 14:55 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
emerge --info (emerge.info,5.83 KB, text/plain) 2015-02-18 08:37 UTC, cono	Details
emerge -pqv (emerge.pqv,136 bytes, text/plain) 2015-02-18 08:37 UTC, cono	Details
build.log (build.log.gz,10.94 KB, application/gzip) 2015-02-18 08:38 UTC, cono	Details
fix patch (fontcache.cpp.diff,886 bytes, patch) 2015-02-20 19:16 UTC, cono	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description cono 2015-02-18 08:37:27 UTC

Created attachment 396776 [details]
emerge --info

After update libicu, openttd goes for update as a dependency and failed with compile error:

/var/tmp/portage/games-simulation/openttd-1.3.3/work/openttd-1.3.3/src/fontcache.cpp: In member function ‘virtual const Sprite* FreeTypeFontCache::GetGlyph(GlyphID)’:
/var/tmp/portage/games-simulation/openttd-1.3.3/work/openttd-1.3.3/src/fontcache.cpp:516:66: error: no matching function for call to ‘max(int, unsigned int)’
  int width  = max(1, slot->bitmap.width + (this->fs == FS_NORMAL));

Comment 1 cono 2015-02-18 08:37:59 UTC

Created attachment 396778 [details]
emerge -pqv

Comment 2 cono 2015-02-18 08:38:41 UTC

Created attachment 396780 [details]
build.log

Comment 3 cono 2015-02-20 19:16:45 UTC

Created attachment 397084 [details, diff]
fix patch

I've made a patch and compiled it locally. Looks like it works.

Comment 4 Mr. Bones. (RETIRED) gentoo-dev

2015-02-20 19:38:08 UTC

Should be fine with 1.4.4

Comment 5 Tomáš Chaloupka 2015-03-26 10:19:03 UTC

Unfortunatelly its not:

/var/tmp/portage/games-simulation/openttd-1.4.4/work/openttd-1.4.4/src/fontcache.cpp: In member function ‘virtual const Sprite* FreeTypeFontCache::GetGlyph(GlyphID)’:
/var/tmp/portage/games-simulation/openttd-1.4.4/work/openttd-1.4.4/src/fontcache.cpp:530:66: error: no matching function for call to ‘max(int, unsigned int)’
  int width  = max(1, slot->bitmap.width + (this->fs == FS_NORMAL));

Comment 6 Tomáš Chaloupka 2015-03-26 14:55:55 UTC

(In reply to Tomáš Chaloupka from comment #5)
> Unfortunatelly its not:
> 
> /var/tmp/portage/games-simulation/openttd-1.4.4/work/openttd-1.4.4/src/
> fontcache.cpp: In member function ‘virtual const Sprite*
> FreeTypeFontCache::GetGlyph(GlyphID)’:
> /var/tmp/portage/games-simulation/openttd-1.4.4/work/openttd-1.4.4/src/
> fontcache.cpp:530:66: error: no matching function for call to ‘max(int,
> unsigned int)’
>   int width  = max(1, slot->bitmap.width + (this->fs == FS_NORMAL));

Hmm sorry,
it was with games-overlay ebuild. Gentoo ebuild seems to work ok