Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 540180 - net-dns/avahi-0.6.31-r7 - files/avahi-0.6.31-build-client-without-daemon.patch removes `test' which breaks BUILD_CLIENT check
Summary: net-dns/avahi-0.6.31-r7 - files/avahi-0.6.31-build-client-without-daemon.patc...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-15 19:42 UTC by Malcolm Lashley
Modified: 2019-11-09 16:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malcolm Lashley 2015-02-15 19:42:50 UTC
emerge net-dns/avahi

[ebuild   R    ] net-dns/avahi-0.6.31-r7::gentoo  USE="dbus gdbm gtk introspection ipv6 mdnsresponder-compat nls qt4 -autoipd -bookmarks -doc -gtk3 -howl-compat -mono -python (-selinux) {-test} -utils" ABI_X86="(64) -32 (-x32)" PYTHON_TARGETS="python2_7" 0 KiB

Mangled gentoo-patch avahi-0.6.31-build-client-without-daemon.patch prevents avahi-compat-libdns_sd from building (it depends on client, which depends on DBUS)






Reproducible: Always

Steps to Reproduce:
1. emerge avahi with the use-flags above.

Actual Results:  
Due to a mangled patch - the following xyes error is emitted by configure - and a bunch of stuff that was otherwise detected OK breaks

    Enable Linux inotify:                      yes
    Enable stack-smashing protection:          yes
    systemd unit directory:                    /usr/lib/systemd/system

./configure: line 28472: xyes: command not found
    Building libavahi-core              yes
    Building avahi-daemon:              yes


Expected Results:  
Configure runs cleanly - detects DBUS etc. builds what I asked for (specifically dns_sd_compat.

Offending line is obviously missing 'test' in this patch:

duality files # cat avahi-0.6.31-build-client-without-daemon.patch
From ce3b83de6aa689c0cefe0b1e85c03a627b537099 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny@gentoo.org>
Date: Mon, 12 May 2014 19:46:22 +0200
Subject: [PATCH] Allow building client without the daemon.

There's no good reason to disallow that, and that's what we specifically
want to do for multilib.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 0e190ba..c56cf01 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1185,7 +1185,7 @@ fi
 
 BUILD_CLIENT="no   (You need avahi-daemon and D-Bus!)"
 
-if test "x$BUILD_DAEMON" = "xyes" -a "x$HAVE_DBUS" = "xyes" ; then
+if "x$HAVE_DBUS" = "xyes" ; then
     BUILD_CLIENT=yes
 fi
 
-- 
1.9.3
Comment 1 Anthony Basile gentoo-dev 2019-11-09 16:48:32 UTC
We're only maintaining avahi-0.7 now.