Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53992 - multiline string literal problems with gphoto
Summary: multiline string literal problems with gphoto
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-15 09:35 UTC by David Bailey
Modified: 2004-10-16 12:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gphoto-0.4.3-r3-RC1.tar.bz2 (gphoto-0.4.3-r3-RC1.tar.bz2,1.48 MB, application/octet-stream)
2004-06-15 10:37 UTC, David Bailey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Bailey 2004-06-15 09:35:14 UTC
Getting these throughout when compiling with gcc 3.2.2- missing terminating " character

Reproducible: Always
Steps to Reproduce:
1. Use gcc 3.2.2 to emerge gphoto 0.4.3-r2
2. Error!


Actual Results:  
gcc -DHAVE_CONFIG_H -I. -I. -I.. -O2 -mcpu=i686 -march=i686 -fomit-frame-pointer
-I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include
-I/usr/X11R6/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -I/usr/X11R6/include -I/usr/X11R6/include -c  -fPIC
-DPIC directory.c -o .libs/directory.lo
directory.c:209:1: missing terminating " character
directory.c: In function `dir_description':
directory.c:210: error: syntax error before "Allows"
directory.c:210: error: stray '\' in program
directory.c:210:21: missing terminating " character
directory.c:212: error: stray '\' in program
directory.c:215:14: missing terminating " character
make[2]: *** [directory.lo] Error 1
make[2]: Leaving directory
`/var/tmp/portage/gphoto-0.4.3-r2/work/gphoto-0.4.3/directory'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gphoto-0.4.3-r2/work/gphoto-0.4.3'
make: *** [all-recursive-am] Error 2


Expected Results:  
Compiled and merged the software.

This is apparently an issue with the newer version of gcc. All of the multiline
string literals need to changed from- 

static char *dir_description() {

        return(
"Browse Directory\nScott Fritzinger <scottf@unr.edu>
Allows the user to \"open\" a directory of
images and all gPhoto functions will work
on those images (HTML Gallery, etc...)\n
This will not work in command-line mode,
due to the high amount of input needed
to set it up.");

}

To-

static char *dir_description() {

        return(
"Browse Directory\nScott Fritzinger <scottf@unr.edu>\n"
"Allows the user to \"open\" a directory of\n"
"images and all gPhoto functions will work\n"
"on those images (HTML Gallery, etc...)\n\n"
"This will not work in command-line mode,\n"
"due to the high amount of input needed\n"
"to set it up.");

}

There are also other places in the code that needs cleaning.
Comment 1 David Bailey 2004-06-15 10:37:54 UTC
Created attachment 33327 [details]
gphoto-0.4.3-r3-RC1.tar.bz2

A candidate for gphoto-0.4.3-r3 to fix the gcc compilation bugs.
Comment 2 foser (RETIRED) gentoo-dev 2004-08-29 08:13:49 UTC
and with newer gcc's (3.3?), do you get the same problems ?
Comment 3 David Bailey 2004-08-30 06:09:44 UTC
Yes, it still occurs with gcc 3.3.3.
Comment 4 Chris Snyder 2004-10-13 13:40:19 UTC
This still hasn't been fixed, Gnome Desktop Team.
Comment 5 Alastair Tse (RETIRED) gentoo-dev 2004-10-16 12:36:42 UTC
Comment on attachment 33327 [details]
gphoto-0.4.3-r3-RC1.tar.bz2

atched source files to allow compiling. It now works under gcc-3.2.2. I'm
sorry, I don't know a lot about creating patch files. There would have to be
several created. Several files were fixed.
Comment 6 Alastair Tse (RETIRED) gentoo-dev 2004-10-16 12:53:39 UTC
fixed in cvs now. however, i'm deprecating gphoto in favour of gphoto2. gphoto is not supported upstream any more, and if a user wishes to use gphoto, they need to understand it isn't supported upstream, hence the mask.