Bug 53965 – media-fonts/corefonts-1-r1 should use eclass

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mark Gibson 2004-06-15 03:50:44 UTC]

Font ebuilds should have to depend on X11.
There are situations where it is desirable to install the fonts
on a server, for use from PHP etc, without having X11 installed.
(I know that corefonts-1.ebuild doesn't have the dependency

Reproducible: Always
Steps to Reproduce:
1. emerge -p /usr/portage/media-fonts/corefonts-1-r1.ebuild

Actual Results:  
Unnecessary dependencies appear:
[ebuild  N    ] x11-misc/ttmkfdir-3.0.9-r1
[ebuild  N    ] media-libs/fontconfig-2.2.2
[ebuild  N    ] app-arch/unzip-5.50-r2
[ebuild  N    ] x11-base/opengl-update-1.5
[ebuild  N    ] x11-base/xfree-4.3.0-r5
[ebuild  N    ] media-fonts/corefonts-1-r1


Expected Results:  
The 'X' USE-flag should be used for any extra X11 support.


I'm aware that corefonts-1.ebuild doesn't have the dependency,
but don't let this disappear without making X11 optional.

[Comment 1 Mark Gibson 2004-06-15 03:52:13 UTC]

Sorry, typo on first line, should read:
Font ebuilds should NOT have to depend on X11.

[Comment 2 Donnie Berkholz (RETIRED) 2004-06-15 12:48:58 UTC]

Probably add X USE flag and RDEP X? ( virtual/x11 )

[Comment 3 Mamoru KOMACHI (RETIRED) 2004-09-29 00:15:05 UTC]

Fixed in CVS.

[Comment 4 Daniel Lawson 2004-09-29 22:32:05 UTC]

Created attachment 40751 [details, diff]
Removes the dependancy upon virtual/x11 

I just synced, and have the new ebuild for this, but it still wants to build
X11 to install this package. The rdep has been added, but the prior dependancy
still exists.

----
KEYWORDS="x86 ~ppc sparc alpha ~mips ~hppa ~ia64 amd64"
IUSE="X"

DEPEND="app-arch/cabextract
	virtual/x11"
RDEPEND="X? ( virtual/x11 )"

----
USE="-X" emerge corefonts-1-r1.ebuild  -p

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] x11-base/opengl-update-1.7.2  
[ebuild  N    ] x11-base/xfree-4.3.0-r7  
[ebuild   R   ] media-fonts/corefonts-1-r1  

----

Patch attached to fix this.

[Comment 5 Mamoru KOMACHI (RETIRED) 2004-09-30 00:35:56 UTC]

No, it should depend on virtual/x11 because it uses mkfontscale 
and mkfontdir in src_install(). Once you installed corefonts you
can safely remove x11. (if you don't need it)

[Comment 6 Mark Gibson 2004-09-30 03:32:50 UTC]

Created attachment 40763 [details, diff]
Depend on virtual/X11 only with USE flag X.

Having to install X11 is not acceptable under certain circumstances
(eg web server).
The X USE flag should be employed to decide whether mkfontscale and
mkfontdir should be run after installation.

[Comment 7 Daniel Lawson 2004-09-30 15:30:11 UTC]

Tested Mark's patch (Comment #6) - works great here.

[Comment 8 foser (RETIRED) 2004-10-01 05:15:55 UTC]

this ebuild should start using the font eclass. Remember when fixing font ebuilds to also adapt them.

[Comment 9 Mamoru KOMACHI (RETIRED) 2004-10-01 05:57:40 UTC]

Added corefonts-1-r2.ebuild, which uses font.eclass.
You don't need to install X11 if X USE flag is not set.