Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539630 - Incomplete/broken link in dev manual
Summary: Incomplete/broken link in dev manual
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal trivial (vote)
Assignee: Gentoo Devmanual Team
URL: https://devmanual.gentoo.org/ebuild-w...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-10 15:30 UTC by Fernando (likewhoa)
Modified: 2016-05-01 03:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
devmanual broken link fix (devmanual-fix-broken-link-539630.diff,1.22 KB, patch)
2015-02-10 15:31 UTC, Fernando (likewhoa)
Details | Diff
updated patch that replaces previous one (devmanual-fix-broken-link-539630-1.diff,1.23 KB, patch)
2015-02-10 19:00 UTC, Fernando (likewhoa)
Details | Diff
devmanual-fix-broken-link-539630-1.diff (devmanual-fix-broken-link-539630-2.diff,1.20 KB, patch)
2015-02-10 19:03 UTC, Fernando (likewhoa)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando (likewhoa) 2015-02-10 15:30:02 UTC
The current devmanual has a broken link which points to the search query's advanced tab but it currently just goes to the standard search tab. This fix includes the proper linkage and also adjustments to the text describing the link.

Reproducible: Always

Steps to Reproduce:
1.click the link near "for lazy people"
2. see no custom settings



Expected Results:  
working linkage
Comment 1 Fernando (likewhoa) 2015-02-10 15:31:52 UTC
Created attachment 396092 [details, diff]
devmanual broken link fix
Comment 2 Ulrich Müller gentoo-dev 2015-02-10 16:08:56 UTC
(In reply to Fernando (likewhoa) from comment #1)
> Created attachment 396092 [details, diff] [details, diff]
> devmanual broken link fix

+select UNCONFIRMED and RESOLVED (RESOLVED is important), then

Why only those, but not CONFIRMED, IN_PROGRESS, and VERIFIED?
Comment 3 Fernando (likewhoa) 2015-02-10 16:10:05 UTC
(In reply to Ulrich Müller from comment #2)
> (In reply to Fernando (likewhoa) from comment #1)
> > Created attachment 396092 [details, diff] [details, diff] [details, diff]
> > devmanual broken link fix
> 
> +select UNCONFIRMED and RESOLVED (RESOLVED is important), then
> 
> Why only those, but not CONFIRMED, IN_PROGRESS, and VERIFIED?

I asked myself the same question but since it wasn't originally mentioned i left them out. Feel free to add as you see fit.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2015-02-10 18:22:31 UTC
(In reply to Fernando (likewhoa) from comment #3)
> (In reply to Ulrich Müller from comment #2)
> > (In reply to Fernando (likewhoa) from comment #1)
> > > Created attachment 396092 [details, diff] [details, diff] [details, diff] [details, diff]
> > > devmanual broken link fix
> > 
> > +select UNCONFIRMED and RESOLVED (RESOLVED is important), then
> > 
> > Why only those, but not CONFIRMED, IN_PROGRESS, and VERIFIED?
> 
> I asked myself the same question but since it wasn't originally mentioned i
> left them out. Feel free to add as you see fit.

Yes I think we need to mention all possible fields. Please attach an updated patch and I will commit it for you.
Comment 5 Fernando (likewhoa) 2015-02-10 19:00:33 UTC
Created attachment 396126 [details, diff]
updated patch that replaces previous one
Comment 6 Fernando (likewhoa) 2015-02-10 19:01:10 UTC
(In reply to Markos Chandras from comment #4)
> (In reply to Fernando (likewhoa) from comment #3)
> > (In reply to Ulrich Müller from comment #2)
> > > (In reply to Fernando (likewhoa) from comment #1)
> > > > Created attachment 396092 [details, diff] [details, diff] [details, diff] [details, diff] [details, diff]
> > > > devmanual broken link fix
> > > 
> > > +select UNCONFIRMED and RESOLVED (RESOLVED is important), then
> > > 
> > > Why only those, but not CONFIRMED, IN_PROGRESS, and VERIFIED?
> > 
> > I asked myself the same question but since it wasn't originally mentioned i
> > left them out. Feel free to add as you see fit.
> 
> Yes I think we need to mention all possible fields. Please attach an updated
> patch and I will commit it for you.

Updated and also removed non-existing fields.
Comment 7 Fernando (likewhoa) 2015-02-10 19:03:47 UTC
Created attachment 396128 [details, diff]
devmanual-fix-broken-link-539630-1.diff

This patch might be better since it suggest to select all possible fields in the status options list.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2015-02-15 09:57:30 UTC
That looks ok. So now please attach a proper git patch and I will commit it for you :)