Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539574 - net-p2p/bitcoin-cli-0.9.3 should depend on dev-libs/leveldb
Summary: net-p2p/bitcoin-cli-0.9.3 should depend on dev-libs/leveldb
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-10 05:03 UTC by Scott Alfter
Modified: 2015-02-24 22:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log for unpatched bitcoin-cli ebuild (build.log,10.76 KB, text/plain)
2015-02-10 16:42 UTC, Scott Alfter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Alfter 2015-02-10 05:03:27 UTC
Bitcoin >=0.8 (IIRC) requires LevelDB, but the bitcoin-cli ebuild doesn't declare this.  Looking at the corresponding bitcoind ebuild, virtual/bitcoin-leveldb should be declared in RDEPEND.

Reproducible: Always




Portage 2.2.14 (python 2.7.9-final-0, default/linux/amd64/13.0, gcc-4.8.3, glibc-2.19-r1, 3.17.8-gentoo-r1 x86_64)
=================================================================
System uname: Linux-3.17.8-gentoo-r1-x86_64-AMD_A4-3300_APU_with_Radeon-tm-_HD_Graphics-with-gentoo-2.2
KiB Mem:     9684036 total,    586912 free
KiB Swap:    2097148 total,   2092444 free
Timestamp of tree: Sat, 07 Feb 2015 04:30:01 +0000
ld GNU ld (Gentoo 2.24 p1.4) 2.24
ccache version 3.1.9 [enabled]
app-shells/bash:          4.2_p53
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.9-r1, 3.3.5-r1
dev-util/ccache:          3.1.9-r4
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.9
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.69
sys-devel/automake:       1.11.6-r1, 1.13.4
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.4
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo salfter nextoo fkmclane
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"                                                            
CXXFLAGS="-O2 -pipe"                                                            
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--autounmask-write --quiet-build=y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirrors.tds.net/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/salfter /var/lib/layman/nextoo /var/lib/layman/fkmclane"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="X acl amd64 apache2 berkdb bzip2 cli cracklib crypt cxx dri fdk ffmpeg fortran gdbm gudev iconv ipv6 jpeg libav mmx modules multilib mysql mysqli ncurses nls nptl openmp pam pcre php png policykit qt4 readline session sse sse2 ssl svg tcpd unicode vhosts zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Scott Alfter 2015-02-10 05:10:22 UTC
I've checked a revised ebuild into my overlay:

https://raw.githubusercontent.com/salfter/portage/master/net-p2p/bitcoin-cli/bitcoin-cli-0.9.3.ebuild
Comment 2 Luke-Jr 2015-02-10 09:49:40 UTC
bitcoin-cli never uses LevelDB, so it definitely should not be in RDEPEND.
Can you test with 0.10.0_rc4 (in the bitcoin overlay)?
Comment 3 Anthony Basile gentoo-dev 2015-02-10 12:13:07 UTC
(In reply to scott-sender-75f28f@alfter.us from comment #0)
> Bitcoin >=0.8 (IIRC) requires LevelDB, but the bitcoin-cli ebuild doesn't
> declare this.  Looking at the corresponding bitcoind ebuild,
> virtual/bitcoin-leveldb should be declared in RDEPEND.

Did you actually hit a bug here, or are you just assuming because of the comparison with bitcoind.  bitcoin-cli is just an rpc client.
Comment 4 Scott Alfter 2015-02-10 16:40:57 UTC
bitcoin-cli won't build without LevelDB.  A build log will be attached momentarily.
Comment 5 Scott Alfter 2015-02-10 16:42:55 UTC
Created attachment 396098 [details]
build log for unpatched bitcoin-cli ebuild

A snippet from the log:

  CXX      main.o
In file included from leveldbwrapper.cpp:5:0:
leveldbwrapper.h:13:24: fatal error: leveldb/db.h: No such file or directory
 #include <leveldb/db.h>
                        ^
compilation terminated.
Comment 6 Scott Alfter 2015-02-10 16:49:26 UTC
(In reply to Luke-Jr from comment #2)
> bitcoin-cli never uses LevelDB, so it definitely should not be in RDEPEND.
> Can you test with 0.10.0_rc4 (in the bitcoin overlay)?

Building now.  BTW, it pulls in LevelDB if it hasn't already been installed.

It finished building as I wrote this.
Comment 7 Anthony Basile gentoo-dev 2015-02-11 13:31:31 UTC
(In reply to scott-sender-75f28f@alfter.us from comment #6)
> (In reply to Luke-Jr from comment #2)
> > bitcoin-cli never uses LevelDB, so it definitely should not be in RDEPEND.
> > Can you test with 0.10.0_rc4 (in the bitcoin overlay)?
> 
> Building now.  BTW, it pulls in LevelDB if it hasn't already been installed.
> 
> It finished building as I wrote this.

Okay this is pretty convincing.  Is it sufficient to just add 

  virtual/bitcoin-leveldb


to DEPEND?
Comment 8 Luke-Jr 2015-02-11 20:03:22 UTC
(In reply to Anthony Basile from comment #7)
> (In reply to scott-sender-75f28f@alfter.us from comment #6)
> > (In reply to Luke-Jr from comment #2)
> > > bitcoin-cli never uses LevelDB, so it definitely should not be in RDEPEND.
> > > Can you test with 0.10.0_rc4 (in the bitcoin overlay)?
> > 
> > Building now.  BTW, it pulls in LevelDB if it hasn't already been installed.
> > 
> > It finished building as I wrote this.
> 
> Okay this is pretty convincing.  Is it sufficient to just add 
> 
>   virtual/bitcoin-leveldb
> 
> 
> to DEPEND?

I'm guessing it's building files it shouldn't be (and throwing the results away). I suppose a DEPEND works for a temporary fix.
Comment 9 Anthony Basile gentoo-dev 2015-02-12 21:08:44 UTC
(In reply to Luke-Jr from comment #8)
> (In reply to Anthony Basile from comment #7)
> > (In reply to scott-sender-75f28f@alfter.us from comment #6)
> > > (In reply to Luke-Jr from comment #2)
> > > > bitcoin-cli never uses LevelDB, so it definitely should not be in RDEPEND.
> > > > Can you test with 0.10.0_rc4 (in the bitcoin overlay)?
> > > 
> > > Building now.  BTW, it pulls in LevelDB if it hasn't already been installed.
> > > 
> > > It finished building as I wrote this.
> > 
> > Okay this is pretty convincing.  Is it sufficient to just add 
> > 
> >   virtual/bitcoin-leveldb
> > 
> > 
> > to DEPEND?
> 
> I'm guessing it's building files it shouldn't be (and throwing the results
> away). I suppose a DEPEND works for a temporary fix.

Luke, I would rather not pull in a dependency we don't need.  Let's figure out what the build system is doing and fix it.
Comment 10 Luke-Jr 2015-02-23 23:22:54 UTC
Tested this is fixed in 0.10.0.