538462 – net-analyzer/dsniff - invalid calculation of Total Length header field in macof.c

Bug 538462 - net-analyzer/dsniff - invalid calculation of Total Length header field in macof.c

Summary: net-analyzer/dsniff - invalid calculation of Total Length header field in mac...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Netmon project

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2015-02-01 19:18 UTC by jan.starke
Modified:	2015-02-07 10:16 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
dsniff-2.4_beta1-r6/macof.c (macof_jasa.patch,552 bytes, patch) 2015-02-01 19:18 UTC, jan.starke	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jan.starke 2015-02-01 19:18:33 UTC

Created attachment 395338 [details, diff]
dsniff-2.4_beta1-r6/macof.c

Hi,

I observed that macof (package dsniff) does not include the size of the IP header in its calculation of the Total Length field.

I sent an email to the author of dsniff about this issue, but I received no answer. So I published a description of the problem (https://janstarke.wordpress.com/2015/02/01/invalid-tcp-segments-created-by-macof/)

Attached to this bug you find a patch which resolves this problem.

Kind regards, Jan

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2015-02-07 10:16:23 UTC

This patch went into -r7. Thanks for the report and patch.