Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53846 - hibernate-2.1.4.ebuild
Summary: hibernate-2.1.4.ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-13 18:07 UTC by Thomas L. Kjeldsen
Modified: 2004-06-14 17:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to the 2.1.3 ebuild (hibernate-ebuild.patch,611 bytes, patch)
2004-06-13 18:11 UTC, Thomas L. Kjeldsen
Details | Diff
hibernate-2.1.4.ebuild (hibernate-2.1.4.ebuild,1.10 KB, text/plain)
2004-06-13 18:13 UTC, Thomas L. Kjeldsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas L. Kjeldsen 2004-06-13 18:07:11 UTC
2.1.4 is out

Reproducible: Always
Steps to Reproduce:
Comment 1 Thomas L. Kjeldsen 2004-06-13 18:11:41 UTC
Created attachment 33190 [details, diff]
patch to the 2.1.3 ebuild

here's a patch that works for me
Comment 2 Thomas L. Kjeldsen 2004-06-13 18:13:02 UTC
Created attachment 33191 [details]
hibernate-2.1.4.ebuild

in case it's easier for someone, here's the new ebuild
Comment 3 Lim Swee Tat (RETIRED) gentoo-dev 2004-06-14 09:36:15 UTC
Closing, it is in portage in another 2 hours or so.  Thanx for reporting. :)
Comment 4 Thomas L. Kjeldsen 2004-06-14 17:06:58 UTC
This is really fast service. Excellent, thanks!


However, next time you touch the ebuild I think you should use the suggested use-the-first-three-characters-from-$PV approach:
S=${WORKDIR}/${PN}-${PV:0:3}

in favour of the current remove-a-substring-from-$PV approach:
S=${WORKDIR}/${PN}-${PV/.3}   (now updated to S=${WORKDIR}/${PN}-${PV/.4})

I know this is nitpicking, and I apologize for that, but the remove-a-substring-from-$PV approach is a O(n) waste of your time, as the substring has to be changed by hand for each(!) new version of hibernate :)


Here is the relevant section from BASH(1):

       ${parameter:offset:length}
              Substring  Expansion.   Expands  to  up  to length characters of
              parameter starting at the character  specified  by  offset.   If
              length  is omitted, expands to the substring of parameter start-
              ing at the character specified by offset.  length and offset are
              arithmetic   expressions   (see  ARITHMETIC  EVALUATION  below).
              length must evaluate to a number greater than or equal to  zero.
              If  offset  evaluates  to  a number less than zero, the value is
              used as an offset from the end of the value  of  parameter.   If
              parameter  is  @,  the  result  is  length positional parameters
              beginning at offset.  If parameter is an array name indexed by @
              or  *,  the  result is the length members of the array beginning
              with ${parameter[offset]}.   Substring  indexing  is  zero-based
              unless  the  positional  parameters  are used, in which case the
              indexing starts at 1.