Bug 538204 – media-sound/jack-audio-connection-kit: use cpu_flags_<arch>_<flag>

• Status: RESOLVED OBSOLETE
• Product: Gentoo Linux

[Description tokiclover 2015-01-29 22:17:31 UTC]

Please use cpu_flags_<arch>_<flag> USE flags instead of the ambiguous old name for clarity.

Thanks

Reproducible: Always

[Comment 1 tokiclover 2015-01-29 22:22:03 UTC]

I won't post a tedious and long patch because the change are fearly simple and strait forward.

The relevant part after removing CPU specifi USE flags:
--
PPC_CPU_FLAGS=(altivec)
X86_CPU_FLAGS=(3dnow mmx sse)
for arch in {PPC,X86}; do
	eval CPU_FLAGS=\"\${${arch}_CPU_FLAGS[@]}\"
	for flag in ${CPU_FLAGS}; do
		cpu_flag=cpu_flags_${arch,,[A-Z]}_${flag%:*}
		eval has "${flag}" "\${CPU_FLAGS_${arch}}" &&
			IUSE+=" +${cpu_flag}" || IUSE+=" ${cpu_flag}"
		CPU_IUSE+=(${flag})
	done
done
unset {PPC,X86}_CPU_FLAGS arch {cpu_,}flag
--
And the edit `altivec' to `cpu_flags_ppc_altivec' and X86 flags to `cpu_flags_x86_<flag>'.

Thanks!

[Comment 2 tokiclover 2015-01-29 22:23:25 UTC]

NOTE: The CPU_IUSE is completly useless and unecessary... sory to have forgotten it.

[Comment 3 tokiclover 2015-01-29 22:30:05 UTC]

So Michal G. was too fast for me... he went with a manual way, but he left altivec (a PPC CPU flag) untouched.

[Comment 4 Michał Górny 2015-01-29 22:38:44 UTC]

Yeah, sorry, didn't look at what I was converting :). We're not doing PPC yet, we need PPC team to establish some conventions first. In the meantime, x86 work provides useful insight.