Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 537336 - [PATCH] games-action/gltron-0.70-r1 does not compile with current toolchain
Summary: [PATCH] games-action/gltron-0.70-r1 does not compile with current toolchain
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-22 11:57 UTC by Martin Väth
Modified: 2015-02-06 22:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fix #define to act in a compatible manner (gltron-toolchain.patch,259 bytes, patch)
2015-01-22 11:57 UTC, Martin Väth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2015-01-22 11:57:49 UTC
Created attachment 394596 [details, diff]
fix #define to act in a compatible manner

With the current toolchain (gcc-4.9.2 and glibc-2.20-r1), gltron does not compile.

The reason is an inconsistent usage of "#define __USE_MISC": Macros like these should be set globally in the beginning and not locally for only some header files.

Apparently, newer versions of gcc/glibc are more picky about this and yield an error. I did no research which versions of gcc/glibc are required to trigger the bug,

I attach a patch which shifts the offending definition at least until the beginning of the corresponding file: This is sufficient to compile it with gcc-4.9.2 and glibc-2.20-r1 (and nonintrusive so that compilation with earlier versions of gcc/glibc continues to work).
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2015-02-06 22:04:12 UTC
well I don't have gcc49 here but the patch looks pretty benign so it's applied.  thanks for the bug report.