Bug 536782 – dev-libs/librdkafka - Apache Kafka C/C++ client library

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thomas Deutschmann (RETIRED) 2015-01-16 15:57:48 UTC]

Created attachment 394096 [details]
librdkafka-0.8.5.ebuild

Hi,

please add the attached ebuild for dev-libs/librdkafka to the tree.

This will be a requirement for the upcoming app-admin/rsyslog-8.7.0 version (I'll fill a bug for rsyslog-8.7.0 shortly). So I think this can be assigned to UltraBug.

[Comment 1 Jeroen Roovers (RETIRED) 2015-01-16 19:02:52 UTC]

Comment on attachment 394096 [details]
librdkafka-0.8.5.ebuild

>inherit eutils
>
>DESCRIPTION="Apache Kafka C/C++ client library."

Description should not end in a dot.

>IUSE="elibc_glibc static-libs"

elibc_glibc should be hidden.

>	econf ${myconf}

     econf $(usex static-libs --enable-static '')

Then you can skip setting the variable.

>src_compile() {
>	# Parallel build is currently broken, see upstream issue #179
>	emake --jobs 1

Fix it? Also, -j1 is the norm not --jobs 1.

[Comment 2 Thomas Deutschmann (RETIRED) 2015-01-16 20:34:13 UTC]

Created attachment 394106 [details]
librdkafka-0.8.5.ebuild-r1

Here's r1 based on Jeroen's feedback:


(In reply to Jeroen Roovers from comment #1)
> >IUSE="elibc_glibc static-libs"
> 
> elibc_glibc should be hidden.

Not sure what you mean with that. I removed "elibc_glibc" for the moment from IUSE.


> >src_compile() {
> >	# Parallel build is currently broken, see upstream issue #179
> >	emake --jobs 1
> 
> Fix it? Also, -j1 is the norm not --jobs 1.

See the comment, I reported this upstream. I don't have a fix at the moment.

I want to keep "--jobs 1" because when writing code I think it is better to stick with long options/parameters for readability.

[Comment 3 Ultrabug 2015-02-23 11:31:28 UTC]

I'd like to better this ebuild / upstream before adding it to tree. I'd rather proceed with #536784 instead.

[Comment 4 Thomas Deutschmann (RETIRED) 2015-02-23 11:33:53 UTC]

Upstream fixed the build issue already, https://github.com/edenhill/librdkafka/issues/179

But yes, we can wait for the next release.

[Comment 5 Thomas Deutschmann (RETIRED) 2016-05-04 12:32:13 UTC]

In tree since 2016-03-14: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93dbc90dcb2df0d6632e93d78eade3f1da127856