Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 536610 - media-tv/kodi-9999: Make visualizations (glspectrum, waveform) optional
Summary: media-tv/kodi-9999: Make visualizations (glspectrum, waveform) optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Xbox project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-01-14 15:11 UTC by hal
Modified: 2015-04-20 20:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xbmc_visualization.patch (xbmc_visualization.patch,1.57 KB, patch)
2015-01-14 15:11 UTC, hal
Details | Diff
metadate_sicualization.patch (metadata_visualization.patch,570 bytes, patch)
2015-01-14 15:12 UTC, hal
Details | Diff
metadata_visualization.patch (metadata_visualization.patch,570 bytes, patch)
2015-01-14 15:13 UTC, hal
Details | Diff
xbmc_visualization.patch (xbmc_visualization.patch,1.54 KB, patch)
2015-01-20 13:49 UTC, hal
Details | Diff
xbmc_visualization.patch (xbmc_visualization.patch,1.79 KB, patch)
2015-01-20 13:58 UTC, hal
Details | Diff
xbmc_visualization.patch (xbmc_visualization.patch,1.79 KB, patch)
2015-04-17 09:03 UTC, hal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hal 2015-01-14 15:11:44 UTC
Created attachment 393976 [details, diff]
xbmc_visualization.patch

Flags have been introduced to make some visualizations (glspectrum, waveform) optional. Patches attached.
Comment 1 hal 2015-01-14 15:12:09 UTC
Created attachment 393978 [details, diff]
metadate_sicualization.patch
Comment 2 hal 2015-01-14 15:13:01 UTC
Created attachment 393980 [details, diff]
metadata_visualization.patch
Comment 3 hal 2015-01-14 15:37:37 UTC
I just found that visualization.vortex is for WIN32 only. So this could be added to the disabled_addons array.
Comment 4 hal 2015-01-20 13:49:59 UTC
Created attachment 394410 [details, diff]
xbmc_visualization.patch

No necessity to remove the compiled visualization addons manually anymore.

./configure --help
...
  --enable-waveform       enable Waveform visualisation (default is yes)
  --enable-spectrum       enable Spectrum visualisation (default is yes)
  --enable-goom           enable GOOM visualisation (default is no)
  --enable-rsxs           enable really slick X screensavers (default is yes)
  --enable-fishbmc        enable FishBMC visualisation (default is yes)
  --enable-projectm       enable ProjectM visualisation (default is yes)
...
Comment 5 hal 2015-01-20 13:58:08 UTC
Created attachment 394412 [details, diff]
xbmc_visualization.patch

Added visualization.vortex to be removed
Comment 6 hal 2015-04-16 00:27:06 UTC
Is there anything else to do in order to get this committed?
Comment 7 SpanKY gentoo-dev 2015-04-16 20:01:10 UTC
the whitespace is broken in your patches ;).  post new ones against the latest kodi ebuild and i'll try to get them in quickly.
Comment 8 hal 2015-04-17 09:03:51 UTC
Created attachment 401442 [details, diff]
xbmc_visualization.patch

Here we go :)
Comment 9 SpanKY gentoo-dev 2015-04-20 20:59:08 UTC
should be all set now in the tree; thanks for the report!

Commit message: Patch by hal to control more visualizers
http://sources.gentoo.org/media-tv/kodi/kodi-9999.ebuild?r1=1.15&r2=1.16
http://sources.gentoo.org/media-tv/kodi/metadata.xml?r1=1.4&r2=1.5