Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 535916 - x11-misc/xdg-utils - /usr/bin/xdg-open: kfmclient_fix_exit_code() - ?
Summary: x11-misc/xdg-utils - /usr/bin/xdg-open: kfmclient_fix_exit_code() - ?
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-07 11:37 UTC by perillamint
Modified: 2015-08-25 09:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description perillamint 2015-01-07 11:37:28 UTC
in kfmclient_fix_edit_code in xdg-open (line 441), it detects version with 

    test "$major" -gt 3 && return $1
    test "$minor" -gt 5 && return $1
    test "$release" -gt 4 && return $1

this code.

It works when version is above 3.5.4. However it could be misbehave in lower version number.

For example, when it gets version 3.4.8, it passes first two checks. but it failes last check and returns $1 instead of 0.

I think it should be fixed like this.

    test "$major" -gt 3 && return $1
    test "$major" -lt 3 && return 0
    test "$minor" -gt 5 && return $1
    test "$minor" -lt 5 && return 0
    test "$release" -gt 4 && return $1
    test "$release" -lt 4 && return 0
    return 0;
Comment 1 Michael Palimaka (kensington) gentoo-dev 2015-01-29 16:52:47 UTC
Out of curiousity, is this bug purely academic, or are you actually still running KDE 3?
Comment 2 perillamint 2015-01-30 12:42:25 UTC
(In reply to Michael Palimaka (kensington) from comment #1)
> Out of curiousity, is this bug purely academic, or are you actually still
> running KDE 3?

Purely academic. I found this while inspecting xdg-open is not working in kde framework 5.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2015-02-04 16:59:50 UTC
I suggest reporting upstream then, I guess there's not much point us carrying a local patch for something we don't use anyway.
Comment 4 Johannes Huber (RETIRED) gentoo-dev 2015-08-25 09:13:09 UTC
Please report it upstream.