Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 535866 - net-misc/ser2net-2.10.0 version bump
Summary: net-misc/ser2net-2.10.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Brendan Horan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-07 02:28 UTC by Brendan Horan
Modified: 2015-02-03 04:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ser2net-2.10.0.ebuild (ser2net-2.10.0.ebuild,814 bytes, text/plain)
2015-01-07 02:28 UTC, Brendan Horan
Details
ser2net-2.10.0.ebuild (ser2net-2.10.0.ebuild,640 bytes, text/plain)
2015-01-08 00:07 UTC, Brendan Horan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Horan 2015-01-07 02:28:59 UTC
Created attachment 393388 [details]
ser2net-2.10.0.ebuild

Upstream has released 2.10.0

I have attached a new ebuild for a version bump.
Set EAPI to 5
No other changes to the ebuild where required.

I have also removed the ~ mask for amd64.
I can't see any reason this can't go stable?

* REPOMAN checks pass
* Built and tested the ebuild.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-07 07:23:24 UTC
Comment on attachment 393388 [details]
ser2net-2.10.0.ebuild

>inherit base autotools

Nothing you use from base.eclass is an improvement here.

>KEYWORDS="amd64 ppc x86"

You should drop all keywords to ~arch.

>DOCS=( "AUTHORS" "NEWS" "README" "ChangeLog" )
>
>src_prepare() {
>	base_src_prepare
>	eautoreconf
>}
>
>src_configure() {
>	local myopts="$(use_with tcpd tcp-wrappers) --with-uucp-locking"
>	econf ${myopts} || die "econf failed"

econf die()s on its own.

The local variable is not needed at all. The original one-liner was more compact and better legible.

>src_install () {
>	base_src_install

The default src_install() is fine here, so "default" in the 2.9.1 ebuild did everything you needed.

>	insinto /etc
>	newins ${PN}.conf ${PN}.conf.dist
>	newinitd "${FILESDIR}/${PN}.initd" ${PN}
>	newconfd "${FILESDIR}/${PN}.confd" ${PN}

You removed two helpful empty lines that distinguished clearly between the normal src_install, the extra file that goes into /etc and the openrc scripts.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-07 07:25:10 UTC
(In reply to Brendan Horan from comment #0)
> No other changes to the ebuild where required.

I beg your pardon?

> I have also removed the ~ mask for amd64.
> I can't see any reason this can't go stable?

Because we have a general rule about waiting 30 days to see what goes wrong (where people can find reasons why it shouldn't go stable as is). Straight-to-stable is reserved for extreme cases.
Comment 3 Brendan Horan 2015-01-07 11:51:24 UTC
Wow I am sorry that ebuild is garbage.
I don't know what happened there.

The only thing that should of changed was EAPI and the version.
Honestly nothing else should of changed :)


I will fix this and re upload the correct ebuild, sorry about that.

Noted on the ~arch keywords.
Comment 4 Brendan Horan 2015-01-08 00:07:25 UTC
Created attachment 393452 [details]
ser2net-2.10.0.ebuild

Correct ebuild file attached.
So sorry for the incorrect one yesterday.
Comment 5 Brendan Horan 2015-01-08 02:06:55 UTC
Only the version has changed.. :) I hope
Comment 6 Brendan Horan 2015-01-19 07:16:47 UTC
Is the new ebuild OK? or do you need me fix anything else ?

Thanks
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-26 08:20:59 UTC
Comment on attachment 393452 [details]
ser2net-2.10.0.ebuild

--- ser2net-2.9.1.ebuild
+++ ser2net-2.10.0.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/ser2net/ser2net-2.9.1.ebuild,v 1.1 2014/04/04 13:17:20 tomwij Exp $
+# $Header: $

 EAPI=5



No changes.
Comment 8 Alex Xu (Hello71) 2015-02-03 02:14:50 UTC
so just to be clear, you want EAPI=5 and the filename to be changed, nothing else.
Comment 9 Brendan Horan 2015-02-03 02:51:36 UTC
I believe so yes. Thanks.
Comment 10 Ben de Groot (RETIRED) gentoo-dev 2015-02-03 04:44:24 UTC
+*ser2net-2.10.0 (03 Feb 2015)
+
+  03 Feb 2015; Ben de Groot <yngwin@gentoo.org> +ser2net-2.10.0.ebuild:
+  version bump (bug #535866)