Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 535852 - media-libs/harfbuzz - libharfbuzz-gobject should be optional
Summary: media-libs/harfbuzz - libharfbuzz-gobject should be optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 22:37 UTC by jshin
Modified: 2015-02-17 17:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jshin 2015-01-06 22:37:42 UTC
libharfbuzz-gobject is always built when glib is used for harfbuzz because the ebuild has the following line:

$(use_with glib gobject)

However, not everybody wants to have an extra library (libharfbuzz-gobject). e.g. CrOS does not. 

I think we can do the following:

1. Add gobject to IUSE
2. Add the following line 
 REQUIRED_USE="gobject? ( glib )"
 
3. Replace the abouve 'use_with' line with 
   $(use_with gobject)



Reproducible: Always

Steps to Reproduce:
1. Enable 'glib' in harfbuzz ebuild 
2.
3.
Actual Results:  
libharfbuzz-gobject.so is created

Expected Results:  
There should be a way to build libharfbuzz with glib but without libharfbuzz-gobject created.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-01-08 07:49:04 UTC
Glib will always come with gobject. Making it optional in harfbuzz does not make sense as it will not lighten downloads if you keep USE=glib and it will most likely not result in a big difference in build time either.
Comment 2 SpanKY gentoo-dev 2015-02-17 11:56:08 UTC
(In reply to Gilles Dartiguelongue from comment #1)

we're not worried about build times.  it installs extra files which are not used and we want to shrink down the installed footprint.

would USE=introspection be more appropriate here ?  no idea what harfbuzz-gobject is actually used for ...
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-02-17 15:58:20 UTC
(In reply to SpanKY from comment #2)
> no idea what harfbuzz-gobject is actually used for ...

Actually, that's a good question.

After lots of grepping and ldd, as far as I can see, the *only* thing in my gnome-3.14 install that uses harfbuzz-gobject is harfbuzz's gobject-introspection bindings.

I think we should make make harfbuzz-gobject optional, controlled either by USE=introspection or a new USE=gobject flag.
Comment 4 Pacho Ramos gentoo-dev 2015-02-17 16:12:17 UTC
I would vote for "introspection" USE
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-02-17 17:19:45 UTC
+*harfbuzz-0.9.38 (17 Feb 2015)
+
+  17 Feb 2015; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +harfbuzz-0.9.38.ebuild, harfbuzz-9999.ebuild:
+  Version bump; libharfbuzz-gobject is now installed only if USE=introspection
+  (bug #535852, thanks to jshin et al).