Bug 534744 – www-client/firefox-34: backport ARM patch for WebRtc_GetCPUFeaturesARM

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Benda Xu 2015-01-05 08:39:26 UTC]

www-client/firefox-34 on ARM fails with

../../media/webrtc/trunk/webrtc/modules/modules_audio_processing/aecm_core.o: In function `WebRtcAecm_InitCore':
aecm_core.c:(.text+0x5f4): undefined reference to `WebRtc_GetCPUFeaturesARM'
../../media/webrtc/trunk/webrtc/modules/modules_audio_processing/nsx_core.o: In function `WebRtcNsx_InitCore':
nsx_core.c:(.text+0xb3c): undefined reference to `WebRtc_GetCPUFeaturesARM'
../../media/webrtc/trunk/webrtc/common_audio/common_audio_common_audio/spl_init.o: In function `InitFunctionPointers':
spl_init.c:(.text+0x4): undefined reference to `WebRtc_GetCPUFeaturesARM'
../../media/webrtc/trunk/webrtc/common_audio/common_audio_common_audio/sinc_resampler.o: In function `webrtc::SincResampler::InitializeCPUSpecificFeatures()':
sinc_resampler.cc:(.text+0xb8): undefined reference to `WebRtc_GetCPUFeaturesARM'

from the incorrect assumption of Android.

It has been fixed upstream at

https://hg.mozilla.org/mozilla-central/rev/b7316b758ef0

but not included in Firefox-34.  Maybe it is a good idea to backport it to support ~arm.

Reproducible: Always

[Comment 1 Ian Stakenvicius (RETIRED) 2015-01-05 17:03:41 UTC]

Firefox-35 will be out in a little more than a week, I'll make sure that this fix is included there.  Given Firefox-34 will be removed when 35 hits the tree, I'm not sure it's worth backporting this right now.

[Comment 2 Ian Stakenvicius (RETIRED) 2015-01-05 17:23:37 UTC]

Indeed, it looks like the patch is already applied in the source tree for firefox-35.0_beta8 (available on mozilla-overlay).  Next version bump will take care of things, and is scheduled to occur on or near Jaunary 14th.

[Comment 3 Benda Xu 2015-01-09 02:41:47 UTC]

Thanks, let's close it as upstream.