Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 534672 - =app-emulation/wine-1.7.33 wine-staging handling improvements
Summary: =app-emulation/wine-1.7.33 wine-staging handling improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on: 534732
Blocks:
  Show dependency tree
 
Reported: 2015-01-04 17:54 UTC by Adam Feldman
Modified: 2015-03-08 07:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wine-1.7.33-r1.ebuild/wine-9999.ebuild (wine-9999.ebuild,15.64 KB, text/plain)
2015-01-04 17:54 UTC, Adam Feldman
Details
metadata.xml (metadata.xml,2.38 KB, text/xml)
2015-01-04 18:52 UTC, Adam Feldman
Details
ebuild.patch (staging.patch,6.98 KB, patch)
2015-01-04 19:27 UTC, Adam Feldman
Details | Diff
metadata.patch (staging-metadata.patch,1.51 KB, patch)
2015-01-04 19:28 UTC, Adam Feldman
Details | Diff
wine-1.7.33-r1.ebuild/wine-9999.ebuild (wine-9999.ebuild,15.97 KB, text/plain)
2015-01-05 03:23 UTC, Adam Feldman
Details
metadata.xml (metadata.xml,2.48 KB, text/xml)
2015-01-05 03:25 UTC, Adam Feldman
Details
ebuild.patch (staging.patch,7.31 KB, patch)
2015-01-05 03:28 UTC, Adam Feldman
Details | Diff
metadata.patch (staging-metadata.patch,1.62 KB, patch)
2015-01-05 03:28 UTC, Adam Feldman
Details | Diff
wine-1.7.33-r1.ebuild/wine-9999.ebuild (wine-1.7.33-r1.ebuild,15.97 KB, text/plain)
2015-01-11 19:09 UTC, Adam Feldman
Details
ebuild.patch (wine-1.7.33-r1.patch,6.92 KB, patch)
2015-01-11 19:10 UTC, Adam Feldman
Details | Diff
Alternative wine-1.7.33-r1 (wine-1.7.33-r1-alt.ebuild,15.97 KB, text/plain)
2015-01-11 19:11 UTC, Adam Feldman
Details
Alternative ebuild.patch (wine-1.7.33-r1-alt.patch,6.92 KB, patch)
2015-01-11 19:11 UTC, Adam Feldman
Details | Diff
wine-1.7.33-r1.ebuild (wine-1.7.33-r5.ebuild,15.73 KB, text/plain)
2015-01-12 12:44 UTC, Adam Feldman
Details
metadata.xml (metadata.xml,2.48 KB, text/xml)
2015-01-12 12:45 UTC, Adam Feldman
Details
wine-1.7.33-r1.ebuild (wine-1.7.33-r5.ebuild,15.65 KB, text/plain)
2015-01-14 03:29 UTC, Adam Feldman
Details
wine-1.7.33-r1.patch (wine-1.7.33-r1.patch,6.67 KB, patch)
2015-01-14 03:36 UTC, Adam Feldman
Details | Diff
metadata.xml (metadata.xml,2.55 KB, text/xml)
2015-01-14 03:39 UTC, Adam Feldman
Details
metadata.patch (metadata.patch,1.48 KB, patch)
2015-01-14 03:39 UTC, Adam Feldman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Feldman gentoo-dev 2015-01-04 17:54:30 UTC
Created attachment 393152 [details]
wine-1.7.33-r1.ebuild/wine-9999.ebuild

The current wine-1.7.33 ebuild has two use flags of pertinence to this discussion "pipelight" and "pulseaudio." The current implementation of the pipelight use flag is basically a full fledged wine-staging patchset, including the pipelight functionality, and the pulseaudio functionality.  Attached is an ebuild which adds an additional use flag, "staging".  When used, staging provides all wine-staging functionality except pulseaudio and pipelight.  The pipelight use flag is now dependent on the existence and use of the staging use flag.  Pulseaudio support has been left functionally where it was: when the pulseaudio flag is used: if staging is used, pulseaudio support will be baked into wine-staging, if staging is not used, pulseaudio support is still used, through the pulseaudio specific patches from wine-staging.

Additionally, the attached ebuild expands upon the upstream change in name and changes all instances of "${COMPHOLIO_P}" to "${STAGING_P}", and all textual instances of Compholio to Wine-Staging.

Currently, the 9999 ebuild is out of date, doesn't function, and uses a versioned wine-staging tarball with a live wine git repo.  Use of a versioned wine-staging tarball is highly recommended against by upstream wine-staging due to the fact that they update their repo whenever one of their patches has been accepted upstream, so by using a versioned tarball, the patching will potentially fail.  The attached ebuild uses a hack with the git-r3 eclass to pull in wine-staging's git repo, as recommended by dwfreed and eroen.
Comment 1 Adam Feldman gentoo-dev 2015-01-04 18:52:24 UTC
Created attachment 393154 [details]
metadata.xml

Updated metadata.xml, adding staging use flag and refactoring "Compholio" references to "Wine-Staging".
Comment 2 Adam Feldman gentoo-dev 2015-01-04 19:27:38 UTC
Created attachment 393158 [details, diff]
ebuild.patch

changes as stated by diff -Naur for ebuild, as requested by eroen.
Comment 3 Adam Feldman gentoo-dev 2015-01-04 19:28:26 UTC
Created attachment 393160 [details, diff]
metadata.patch

changes as stated by diff -Naur for metadata.xml, as requested by eroen.
Comment 4 Adam Feldman gentoo-dev 2015-01-05 03:23:00 UTC
Created attachment 393190 [details]
wine-1.7.33-r1.ebuild/wine-9999.ebuild

updated as per bug 534732
Comment 5 Adam Feldman gentoo-dev 2015-01-05 03:25:43 UTC
Created attachment 393192 [details]
metadata.xml

updated as per bug 534732
Comment 6 Adam Feldman gentoo-dev 2015-01-05 03:28:08 UTC
Created attachment 393194 [details, diff]
ebuild.patch

updated as per bug 534732
Comment 7 Adam Feldman gentoo-dev 2015-01-05 03:28:37 UTC
Created attachment 393196 [details, diff]
metadata.patch

updated as per bug 534732
Comment 8 Adam Feldman gentoo-dev 2015-01-11 19:09:43 UTC
Created attachment 393724 [details]
wine-1.7.33-r1.ebuild/wine-9999.ebuild

Fix tab issue
Comment 9 Adam Feldman gentoo-dev 2015-01-11 19:10:23 UTC
Created attachment 393726 [details, diff]
ebuild.patch

Fix tab issue
Comment 10 Adam Feldman gentoo-dev 2015-01-11 19:11:31 UTC
Created attachment 393728 [details]
Alternative wine-1.7.33-r1

The previously proposed patch disables dxtn support at the patch and configure level.  Due to the way that Wine-Staging currently applies its patches, this makes it impossible to decouple it from CSMT support.  This alternative, proposed by the folks at wine-staging, removes dxtn support only via configure, so that users can still have CSMT support (without dxtn).  I've opted to leave the patch line in, but commented, but obviously, you can choose to omit it if desired.  This should reflect however you choose to handle it in bug 534732.
Comment 11 Adam Feldman gentoo-dev 2015-01-11 19:11:55 UTC
Created attachment 393730 [details, diff]
Alternative ebuild.patch

The previously proposed patch disables dxtn support at the patch and configure level.  Due to the way that Wine-Staging currently applies its patches, this makes it impossible to decouple it from CSMT support.  This alternative, proposed by the folks at wine-staging, removes dxtn support only via configure, so that users can still have CSMT support (without dxtn).  I've opted to leave the patch line in, but commented, but obviously, you can choose to omit it if desired.  This should reflect however you choose to handle it in bug 534732.
Comment 12 Adam Feldman gentoo-dev 2015-01-12 02:32:09 UTC
Changed from >= to = due to bug 536378
Comment 13 Adam Feldman gentoo-dev 2015-01-12 12:24:44 UTC
Comment on attachment 393724 [details]
wine-1.7.33-r1.ebuild/wine-9999.ebuild

ryao via IRC stated preference for alt ebuild
Comment 14 Adam Feldman gentoo-dev 2015-01-12 12:25:01 UTC
Comment on attachment 393726 [details, diff]
ebuild.patch

ryao via IRC stated preference for alt patch
Comment 15 Adam Feldman gentoo-dev 2015-01-12 12:44:38 UTC
Created attachment 393786 [details]
wine-1.7.33-r1.ebuild

This is the final version, including the now renamed (and previously unused) use flag txc_dxtn to s3tc.
Comment 16 Adam Feldman gentoo-dev 2015-01-12 12:45:03 UTC
Created attachment 393788 [details]
metadata.xml
Comment 17 Adam Feldman gentoo-dev 2015-01-14 03:29:38 UTC
Created attachment 393916 [details]
wine-1.7.33-r1.ebuild

Minor QA fixes from dwfreed and eroen
Comment 18 Adam Feldman gentoo-dev 2015-01-14 03:36:37 UTC
Created attachment 393918 [details, diff]
wine-1.7.33-r1.patch
Comment 19 Adam Feldman gentoo-dev 2015-01-14 03:39:39 UTC
Created attachment 393920 [details]
metadata.xml
Comment 20 Adam Feldman gentoo-dev 2015-01-14 03:39:58 UTC
Created attachment 393922 [details, diff]
metadata.patch
Comment 21 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-03-08 07:16:31 UTC
Fixed, I've imported NP-Hardass's overlay changes into our 9999 and 1.7.38.